hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-147) Add support for CPU isolation/monitoring of containers
Date Sat, 06 Oct 2012 20:15:03 GMT

    [ https://issues.apache.org/jira/browse/YARN-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470926#comment-13470926
] 

Alejandro Abdelnur edited comment on YARN-147 at 10/6/12 8:14 PM:
------------------------------------------------------------------


*CgroupsLCEResourcesHandler*

a few lines exceed 80 chars, reformat

*CgroupsLCEResourcesHandler.setConf()*

move these assignments to init()
cgroupMount, default should be true, so the mounts are created if they don't exist
 cgroupMountPath, if there is no default we should fail if not set, can't we have a sensible
default?
 
*CgroupsLCEResourcesHandler.pathForCgroup()*

default value for cgroupPrefix has '/', here will produce a '//' in the path

*CgroupsLCEResourcesHandler.updateCgroup()*

LOG.debug should be within an IF LOG.DebugEnabled BLOCK to avoid concatenation of the message
if not logging.

The  writer close should be done in a finally after checking f != null. this is generating
the findbugs warning

*CgroupsLCEResourcesHandler.parseMtab()*

Why not move the filereader constructor to the try block below

Nf the filereader cannot be open/read, is this acceptable or should stop execution by throwing
exception?

No need to close fREader, closing in takes care of.

*container-executor.c mount_cgroup()*

Use an ELSE block to avoid return in the middle of the function.


                
      was (Author: tucu00):
    patch with comments on top of original patch, all comments start with //TUCU: (for easy
search).
                  
> Add support for CPU isolation/monitoring of containers
> ------------------------------------------------------
>
>                 Key: YARN-147
>                 URL: https://issues.apache.org/jira/browse/YARN-147
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.0.3-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Andrew Ferguson
>             Fix For: 2.0.3-alpha
>
>         Attachments: YARN-3.patch
>
>
> This is a clone for YARN-3 to be able to submit the patch as YARN-3 does not show the
SUBMIT PATCH button.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message