hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-147) Add support for CPU isolation/monitoring of containers
Date Mon, 15 Oct 2012 17:10:03 GMT

    [ https://issues.apache.org/jira/browse/YARN-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476268#comment-13476268
] 

Alejandro Abdelnur commented on YARN-147:
-----------------------------------------

Andrew, thanks for updating the patch. Mostly minor stuff:

* CgroupsLCEResourcesHandler has an unused import for FileNotFoundException
* CgroupsLCEResourcesHandler, on the double '//', on the init() method, trim the '/' is present
 at the beginning or end of the cgroupPrefix
* CgroupsLCEResourcesHandler, parseMtab, no need have a local var for the fReader, the FileReader
creation could be done directly in the BufferedReader constructor.
* CgroupsLCEResourcesHandler, parseMtab, the last exception should print MTAB_FILE instead
the BufferReader instance.
* CgroupsLCEResourcesHandler, on parseMtab error I think we should thrown an exception to
halt things. My reasoning is that if I've configured things to use cgroups, I'd expect them
to be working as opposed to have a warning message lost in the logs. This would help identify
misconfigurations.

                
> Add support for CPU isolation/monitoring of containers
> ------------------------------------------------------
>
>                 Key: YARN-147
>                 URL: https://issues.apache.org/jira/browse/YARN-147
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.0.3-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Andrew Ferguson
>             Fix For: 2.0.3-alpha
>
>         Attachments: YARN-147-v1.patch, YARN-3.patch
>
>
> This is a clone for YARN-3 to be able to submit the patch as YARN-3 does not show the
SUBMIT PATCH button.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message