hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-163) Retrieving container log via NM webapp can hang with multibyte characters in log
Date Wed, 17 Oct 2012 14:58:04 GMT

    [ https://issues.apache.org/jira/browse/YARN-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477933#comment-13477933
] 

Hadoop QA commented on YARN-163:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12549420/YARN-163.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/94//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/94//console

This message is automatically generated.
                
> Retrieving container log via NM webapp can hang with multibyte characters in log
> --------------------------------------------------------------------------------
>
>                 Key: YARN-163
>                 URL: https://issues.apache.org/jira/browse/YARN-163
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 0.23.3, 2.0.0-alpha
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: YARN-163.patch
>
>
> ContainerLogsBlock.printLogs currently assumes that skipping N bytes in the log file
is the same as skipping N characters, but that is not true when the log contains multibyte
characters.  This can cause the loop that skips a portion of the log to try to skip past the
end of the file and loop forever (or until Jetty kills the worker thread).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message