hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-163) Retrieving container log via NM webapp can hang with multibyte characters in log
Date Wed, 17 Oct 2012 14:42:03 GMT

    [ https://issues.apache.org/jira/browse/YARN-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477920#comment-13477920

Robert Joseph Evans commented on YARN-163:

I wish there were some tests for the patch, but I can see how that is difficult for this,
because there were no tests to begin with.  My only comment for this is that now that we are
skipping using a InputStream instead of a Reader, could you also switch the code to use IOUtils.skipFully?
> Retrieving container log via NM webapp can hang with multibyte characters in log
> --------------------------------------------------------------------------------
>                 Key: YARN-163
>                 URL: https://issues.apache.org/jira/browse/YARN-163
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 0.23.3, 2.0.0-alpha
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: YARN-163.patch
> ContainerLogsBlock.printLogs currently assumes that skipping N bytes in the log file
is the same as skipping N characters, but that is not true when the log contains multibyte
characters.  This can cause the loop that skips a portion of the log to try to skip past the
end of the file and loop forever (or until Jetty kills the worker thread).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message