hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-178) Fix custom ProcessTree instance creation
Date Mon, 22 Oct 2012 16:46:15 GMT

    [ https://issues.apache.org/jira/browse/YARN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481492#comment-13481492
] 

Robert Joseph Evans commented on YARN-178:
------------------------------------------

I have one small issue with the patch.  In RefelctionUtils.newInstance when it catches an
exception it wraps it in a RuntimeException and then throws it, this patch will instead output
a small log message.  I would prefer to see it do the same thing as reflectionUtils for compatibility
reasons.  Other then that the patch looks good to me.
                
> Fix custom ProcessTree instance creation
> ----------------------------------------
>
>                 Key: YARN-178
>                 URL: https://issues.apache.org/jira/browse/YARN-178
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 0.23.5
>            Reporter: Radim Kolar
>            Priority: Critical
>         Attachments: pstree-instance.txt
>
>
> 1. In current pluggable resourcecalculatorprocesstree is not passed root process id to
custom implementation making it unusable.
> 2. pstree do not extend Configured as it should
> Added constructor with pid argument with testsuite. Also added test that pstree is correctly
configured.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message