hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-147) Add support for CPU isolation/monitoring of containers
Date Fri, 19 Oct 2012 19:52:12 GMT

    [ https://issues.apache.org/jira/browse/YARN-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480319#comment-13480319
] 

Colin Patrick McCabe commented on YARN-147:
-------------------------------------------

{{get_kv_key}}, {{get_kv_value}}: thanks for implementing the API I suggested.  It looks a
lot better.  You might consider using {{strspn}} to simplify the code a bit (it returns a
number of bytes, rather than a pointer, like {{index}} does.)  However, this is up to you
(it's fine as-is).  It's more traditional to put the doxygen into the header file than the
{{.c}} file.  Header files tend to define an interface, so that's where I go to find out how
that interface should be used.

{{mount_cgroup}}: it looks like if {{result = -1}}, the call to {{fprintf}} will print out
{{errno}}, which has not been set.  You could either set {{errno}} instead of {{result}} in
the preceding code, or restructure the code a bit.
                
> Add support for CPU isolation/monitoring of containers
> ------------------------------------------------------
>
>                 Key: YARN-147
>                 URL: https://issues.apache.org/jira/browse/YARN-147
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.0.3-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Andrew Ferguson
>             Fix For: 2.0.3-alpha
>
>         Attachments: YARN-147-v1.patch, YARN-147-v2.patch, YARN-147-v3.patch, YARN-147-v4.patch,
YARN-3.patch
>
>
> This is a clone for YARN-3 to be able to submit the patch as YARN-3 does not show the
SUBMIT PATCH button.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message