hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Ferguson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-147) Add support for CPU isolation/monitoring of containers
Date Thu, 18 Oct 2012 21:34:04 GMT

    [ https://issues.apache.org/jira/browse/YARN-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479387#comment-13479387
] 

Andrew Ferguson commented on YARN-147:
--------------------------------------

hi Colin,

thanks for looking at the native code. since the changes were pretty extensive, would you
mind taking a careful look again? if it's easier for you, the incremental changes can be seen
here:
https://github.com/adferguson/hadoop-common/commits/adf-yarn-147

I hope I've faithfully implemented the new key-value API you suggested -- let me know if that's
not the case.

If the mount fails, I let the exception bubble all the way up to stop the NodeManager, as
Tucu suggested before about a different error.

The one thing I did not do is change the open / write / close methods to fopen / fprintf /
fclose, as the rest of the native code does not use those methods. Which would you prefer
to see: adjust my patch to use fopen, etc., or fix my use of open, etc.?

Yes, I totally agree that it would be better if main.c used getopt_long; it definitely smells
like another JIRA to me. :-)


thanks!
Andrew
                
> Add support for CPU isolation/monitoring of containers
> ------------------------------------------------------
>
>                 Key: YARN-147
>                 URL: https://issues.apache.org/jira/browse/YARN-147
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.0.3-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Andrew Ferguson
>             Fix For: 2.0.3-alpha
>
>         Attachments: YARN-147-v1.patch, YARN-147-v2.patch, YARN-147-v3.patch, YARN-3.patch
>
>
> This is a clone for YARN-3 to be able to submit the patch as YARN-3 does not show the
SUBMIT PATCH button.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message