hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-23) FairScheduler: FSQueueSchedulable#updateDemand() - potential redundant aggregation
Date Thu, 06 Sep 2012 22:02:08 GMT

    [ https://issues.apache.org/jira/browse/YARN-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450091#comment-13450091
] 

Karthik Kambatla commented on YARN-23:
--------------------------------------

Here is the output of running test-patch locally:
{noformat}
+1 overall.  

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version ) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.
{noformat}
                
> FairScheduler: FSQueueSchedulable#updateDemand() - potential redundant aggregation
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-23
>                 URL: https://issues.apache.org/jira/browse/YARN-23
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>    Affects Versions: 2.1.0-alpha
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: trunk-MR-4518.patch, trunk-MR-4518.patch, YARN-23.patch, YARN-23.patch
>
>
> In FS, FSQueueSchedulable#updateDemand() limits the demand to maxTasks only after iterating
though all the pools and computing the final demand. 
> By checking if the demand has reached maxTasks in every iteration, we can avoid redundant
work, at the expense of one condition check every iteration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message