hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-23) FairScheduler: PoolSchedulable#updateDemand() - potential redundant aggregation
Date Mon, 13 Aug 2012 23:53:37 GMT

    [ https://issues.apache.org/jira/browse/YARN-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433739#comment-13433739

Alejandro Abdelnur commented on YARN-23:

* don't do 2 log statements for info that is related, as the RM is heavily multithreaded the
my end up in between other log lines.
* wrap the LOG.debug() with an 'if (LOG.isDebugEnabled())', to avoid the construction of string
concatenation when debug is not enabled.
* wouldn't you want to log the fact that demand >= maxRes, which triggers your loop exit?
> FairScheduler: PoolSchedulable#updateDemand() - potential redundant aggregation
> -------------------------------------------------------------------------------
>                 Key: YARN-23
>                 URL: https://issues.apache.org/jira/browse/YARN-23
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>    Affects Versions: 2.1.0-alpha
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: MR-4518_branch1.patch, trunk-MR-4518.patch, trunk-MR-4518.patch
> In FS, PoolSchedulable#updateDemand() limits the demand to maxTasks only after iterating
though all the pools and computing the final demand. 
> By checking if the demand has reached maxTasks in every iteration, we can avoid redundant
work, at the expense of one condition check every iteration.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message