From yarn-dev-return-29232-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu Jan 4 13:03:04 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 36A9218077B for ; Thu, 4 Jan 2018 13:03:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 268E0160C28; Thu, 4 Jan 2018 12:03:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6E099160C2B for ; Thu, 4 Jan 2018 13:03:03 +0100 (CET) Received: (qmail 47745 invoked by uid 500); 4 Jan 2018 12:03:02 -0000 Mailing-List: contact yarn-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-dev@hadoop.apache.org Received: (qmail 47631 invoked by uid 99); 4 Jan 2018 12:03:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jan 2018 12:03:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D8D681808BA for ; Thu, 4 Jan 2018 12:03:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.011 X-Spam-Level: X-Spam-Status: No, score=-108.011 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id vyt3EaCuvzMH for ; Thu, 4 Jan 2018 12:03:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E018C5F3D0 for ; Thu, 4 Jan 2018 12:03:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7483DE002B for ; Thu, 4 Jan 2018 12:03:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3B822240EA for ; Thu, 4 Jan 2018 12:03:00 +0000 (UTC) Date: Thu, 4 Jan 2018 12:03:00 +0000 (UTC) From: "Jinjiang Ling (JIRA)" To: yarn-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (YARN-7698) A misleading variable's name in ApplicationAttemptEventDispatcher MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Jinjiang Ling created YARN-7698: ----------------------------------- Summary: A misleading variable's name in ApplicationAttemptEventDispatcher Key: YARN-7698 URL: https://issues.apache.org/jira/browse/YARN-7698 Project: Hadoop YARN Issue Type: Improvement Components: resourcemanager Reporter: Jinjiang Ling Assignee: Jinjiang Ling Priority: Minor I find there are two variables named "appAttemptId" in ApplicationAttemptEventDispatcher. {code:java} public static final class ApplicationAttemptEventDispatcher implements EventHandler { .... public void handle(RMAppAttemptEvent event) { ApplicationAttemptId appAttemptID = event.getApplicationAttemptId(); ApplicationId appAttemptId = appAttemptID.getApplicationId(); .... } {code} The first one is named as "{color:red}appAttemptID{color}" which is the true attempt id. The other one is named as "{color:red}appAttemptId{color}", but I think it's currect name should be "appId". I'm not sure there are any reason to name the application id as "appAttemptId". But I think two "appAttemptId" in one function may cause some misleading, so it's better to fix the second one to "appId" -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-dev-help@hadoop.apache.org