Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9C36F200B7C for ; Thu, 8 Sep 2016 17:08:56 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9AC80160ABD; Thu, 8 Sep 2016 15:08:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E0D31160AAD for ; Thu, 8 Sep 2016 17:08:55 +0200 (CEST) Received: (qmail 44570 invoked by uid 500); 8 Sep 2016 15:08:51 -0000 Mailing-List: contact yarn-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-dev@hadoop.apache.org Received: (qmail 43888 invoked by uid 99); 8 Sep 2016 15:08:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Sep 2016 15:08:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 57A4E1A07BA; Thu, 8 Sep 2016 15:08:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.528 X-Spam-Level: X-Spam-Status: No, score=-1.528 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RP_MATCHES_RCVD=-1.426, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=effectivemachines.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id uxwfYc-U3V2v; Thu, 8 Sep 2016 15:08:46 +0000 (UTC) Received: from effectivemachines.com (effectivemachines.com [104.236.136.112]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 8B4135F30B; Thu, 8 Sep 2016 15:08:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by effectivemachines.com (Postfix) with ESMTP id 1365E1644D4; Thu, 8 Sep 2016 08:08:38 -0700 (PDT) Received: from effectivemachines.com ([127.0.0.1]) by localhost (effectivemachines.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 9qt_ludFb8cu; Thu, 8 Sep 2016 08:08:37 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by effectivemachines.com (Postfix) with ESMTP id 9D107165161; Thu, 8 Sep 2016 08:08:37 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.9.2 effectivemachines.com 9D107165161 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=effectivemachines.com; s=D35149BA-5A53-11E6-AF53-2EA667C55D35; t=1473347317; bh=OMvRy3XY+gML+73ChdVBKslLQ889gBOFCuI/7jr/u6U=; h=Content-Type:Mime-Version:Subject:From:Date: Content-Transfer-Encoding:Message-Id:To; b=S3IGmol43Ae1qS0Hi/GpFhpTbnowsbkvhr8wc931Ed0vZ0PW+QAomJwPFhH8wR1VR 701u04Fctj9h8QzMbrcFQjrYpjf/ywB0Sqxa2XJcjIEXOJg29pJZzvQoEH090EYhl4 vNSoReM3HfJYMk2NZRnXwmI4qtbu4RCE6df9+ghU= X-Virus-Scanned: amavisd-new at effectivemachines.com Received: from effectivemachines.com ([127.0.0.1]) by localhost (effectivemachines.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3kQS7FVIoCG7; Thu, 8 Sep 2016 08:08:37 -0700 (PDT) Received: from dhcp-201.private.iobm.com (108-193-1-249.lightspeed.sntcca.sbcglobal.net [108.193.1.249]) by effectivemachines.com (Postfix) with ESMTPSA id 4BF241644D4; Thu, 8 Sep 2016 08:08:37 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [VOTE] Merge HADOOP-13341 From: Allen Wittenauer In-Reply-To: Date: Thu, 8 Sep 2016 08:08:58 -0700 Cc: Hadoop Common , "yarn-dev@hadoop.apache.org" , "hdfs-dev@hadoop.apache.org" , "mapreduce-dev@hadoop.apache.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <1D8BF1EF-AA55-47D9-A50B-B5970A97DBA9@effectivemachines.com> To: Steve Loughran X-Mailer: Apple Mail (2.3124) archived-at: Thu, 08 Sep 2016 15:08:56 -0000 > On Sep 8, 2016, at 2:50 AM, Steve Loughran = wrote: >=20 > I'm trying to do the review effort here even though I don't know = detailed bash, as I expect I don't know any less than others, and what = better way to learn than reviewing code written by people that do know = bash?=20 Just a heads up that I'm using bash variable references. While = not exactly rare, they are uncommon. [We use them in lots of places in = the shell code already, so no new ground being broken.] =20 > Could you submit a PR of that HADOOP-13341 branch, so I can review it = there. Sure. https://github.com/apache/hadoop/pull/126 has been = opened. Thanks!= --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-dev-help@hadoop.apache.org