hadoop-yarn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Wangda Tan <wheele...@gmail.com>
Subject Re: [Discuss] Merge YARN-3368 to trunk
Date Thu, 22 Sep 2016 21:03:38 GMT
On Thu, Sep 22, 2016 at 2:01 PM, Allen Wittenauer <aw@effectivemachines.com>

> > On Sep 22, 2016, at 1:24 PM, Wangda Tan <wheeleast@gmail.com> wrote:
> > Actually I'm not trying to debate about if it is necessary to make the
> UI project following Hadoop's rules. The answer is always yes to me: we
> should follow Hadoop's guide for any of sub project. We're trying to make
> it follow Hadoop code style for the new sub project. For example, we use
> the same indent rules (2 spaces) in all JS files.
> >
> > But what I want to discuss is, does these files violate existing Hadoop
> code style guide? I'm not be able to find rules states that dot-files or
> files which are used by developing purpose should not be added to source
> tree. Could you please share the link to the guide.
>         We're talking past each other.
>         If these files enforce the style guidelines, then pick one:
>                 * move to the root of the source tree
>         If they don't enforce the style guidelines, then pick one:
>                 * remove
>                 or
>                 * fix so they do and then moved to the root of the source
> tree

Oh OK I realized you were specifically taking about the editor style file
inside UI project, I'm OK to remove it.

> > I will file a Yetus issue later, hopefully it should be a pretty simple
> change. Could we enable profile for only specific Hadoop branch?
>         Nope.  It's all or nothing.

Since Maven won't fail if specified profile doesn't exist, so it should be
safe to enable it for all.

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message