Return-Path: X-Original-To: apmail-hadoop-yarn-dev-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AACDC18F82 for ; Tue, 17 Nov 2015 07:49:11 +0000 (UTC) Received: (qmail 22840 invoked by uid 500); 17 Nov 2015 07:49:11 -0000 Delivered-To: apmail-hadoop-yarn-dev-archive@hadoop.apache.org Received: (qmail 22668 invoked by uid 500); 17 Nov 2015 07:49:11 -0000 Mailing-List: contact yarn-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-dev@hadoop.apache.org Delivered-To: mailing list yarn-dev@hadoop.apache.org Received: (qmail 22614 invoked by uid 99); 17 Nov 2015 07:49:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Nov 2015 07:49:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id F233C2C1F51 for ; Tue, 17 Nov 2015 07:49:10 +0000 (UTC) Date: Tue, 17 Nov 2015 07:49:10 +0000 (UTC) From: "Tao Jie (JIRA)" To: yarn-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (YARN-4363) In TestFairScheduler, testcase should not create FairScheduler redundantly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Tao Jie created YARN-4363: ----------------------------- Summary: In TestFairScheduler, testcase should not create FairScheduler redundantly Key: YARN-4363 URL: https://issues.apache.org/jira/browse/YARN-4363 Project: Hadoop YARN Issue Type: Test Components: fairscheduler Affects Versions: 2.6.0 Reporter: Tao Jie Priority: Trivial I am trying to make some improvement on fairscheduler, but get some test failure on TestFairScheduler, due to redundant FairScheduler creation: In TestFairScheduler, FairScheduler and RM is created, then set RMContext of RM to scheduler. {code} @Before public void setUp() throws IOException { scheduler = new FairScheduler(); conf = createConfiguration(); resourceManager = new MockRM(conf); scheduler.setRMContext(resourceManager.getRMContext()); } {code} However in several case, scheduler is renewed, as a result RMcontext in scheduler is null. {code} @Test public void testMinZeroResourcesSettings() throws IOException { scheduler = new FairScheduler(); YarnConfiguration conf = new YarnConfiguration(); ... scheduler.init(conf); {code} Then do scheduler.init(conf), I get a NPE(I try to get something from RMContext in scheduler initialization). So FairScheduler should not be renewed in test block. -- This message was sent by Atlassian JIRA (v6.3.4#6332)