Return-Path: X-Original-To: apmail-hadoop-yarn-dev-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1AF1B17B2F for ; Mon, 6 Apr 2015 20:43:18 +0000 (UTC) Received: (qmail 22523 invoked by uid 500); 6 Apr 2015 20:43:12 -0000 Delivered-To: apmail-hadoop-yarn-dev-archive@hadoop.apache.org Received: (qmail 22402 invoked by uid 500); 6 Apr 2015 20:43:12 -0000 Mailing-List: contact yarn-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-dev@hadoop.apache.org Delivered-To: mailing list yarn-dev@hadoop.apache.org Received: (qmail 22136 invoked by uid 99); 6 Apr 2015 20:43:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Apr 2015 20:43:12 +0000 Date: Mon, 6 Apr 2015 20:43:12 +0000 (UTC) From: "Ashwin Shankar (JIRA)" To: yarn-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (YARN-3453) Fair Scheduler : Parts of preemption logic uses DefaultResourceCalculator even in DRF mode causing thrashing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Ashwin Shankar created YARN-3453: ------------------------------------ Summary: Fair Scheduler : Parts of preemption logic uses Defau= ltResourceCalculator even in DRF mode causing thrashing Key: YARN-3453 URL: https://issues.apache.org/jira/browse/YARN-3453 Project: Hadoop YARN Issue Type: Bug Components: fairscheduler Affects Versions: 2.6.0 Reporter: Ashwin Shankar There are two places in preemption code flow where DefaultResourceCalculato= r is used, even in DRF mode. Which basically results in more resources getting preempted than needed, an= d those extra preempted containers aren=E2=80=99t even getting to the =E2= =80=9Cstarved=E2=80=9D queue since scheduling logic is based on DRF's Calcu= lator. Following are the two places : 1. {code:title=3DFSLeafQueue.java|borderStyle=3Dsolid} private boolean isStarved(Resource share) {code} A queue shouldn=E2=80=99t be marked as =E2=80=9Cstarved=E2=80=9D if the dom= inant resource usage is >=3D fair/minshare. 2. {code:title=3DFairScheduler.java|borderStyle=3Dsolid} protected Resource resToPreempt(FSLeafQueue sched, long curTime) {code} -------------------------------------------------------------- One more thing that I believe needs to change in DRF mode is : during a pre= emption round,if preempting a few containers results in satisfying needs of= a resource type, then we should exit that preemption round, since the cont= ainers that we just preempted should bring the dominant resource usage to m= in/fair share. -- This message was sent by Atlassian JIRA (v6.3.4#6332)