Mailing-List: contact yarn-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-dev@hadoop.apache.org
Received-SPF: pass (nike.apache.org: domain of zshen@hortonworks.com
 designates 209.85.220.47 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CABbyifOvYM9XW2wJOF6WEogVV4L2QrJDFZK-ig8FXPkO2Gn0EQ@mail.gmail.com>
References: 
 <CABbyifPsPuGAm-Y3dVEm+az6KpNYXBYpd6pwUj481W6eRFN21g@mail.gmail.com>
	<CA+4kjVt1DKCicBUG9tQAwqxNJYb=UmNDAkLbe3Xz4+ubrg_qWA@mail.gmail.com>
	<CABbyifOvYM9XW2wJOF6WEogVV4L2QrJDFZK-ig8FXPkO2Gn0EQ@mail.gmail.com>
Date: Mon, 29 Dec 2014 10:23:30 -0800
Message-ID: 
 <CAJS6+b6oShMD66YoVASdua=PuL1QQg2fSwO4o5RUnz46HMvJvg@mail.gmail.com>
Subject: Re: Upgrading findbugs
From: Zhijie Shen <zshen@hortonworks.com>
To: "common-dev@hadoop.apache.org" <common-dev@hadoop.apache.org>
Cc: "hdfs-dev@hadoop.apache.org" <hdfs-dev@hadoop.apache.org>,
	"yarn-dev@hadoop.apache.org" <yarn-dev@hadoop.apache.org>,
	"mapreduce-dev@hadoop.apache.org" <mapreduce-dev@hadoop.apache.org>
Content-Type: multipart/alternative; boundary=001a11c2d7d4a835fb050b5ef8f1

--001a11c2d7d4a835fb050b5ef8f1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Findbugs warnings are cleaned up at YARN side. Thanks for the contribution
from Li Lu and Varun Saxena!

On Thu, Dec 18, 2014 at 2:44 PM, Haohui Mai <hmai@hortonworks.com> wrote:

> So far we made great progress on fixing findbugs warnings. We're free of
> findbugs warnings in hdfs, nfs, and a couple other sub projects. There ar=
e
> two findbugs warnings left in hadoop-common. I saw there are some
> progresses on the YARN side as well.
>
> Thanks very much for the contributors (Brandon Li, Li Lu, and many others=
)
> that have worked on this. We have a cleaner code base now, and the newer
> findbugs can help us to catch more issues during pre-commits. :-)
>
> I plan to finish the remaining work on in 2.7 timeframe. Thanks again for
> contribution.
>
> Thanks,
> Haohui
>
>
> On Tue, Dec 9, 2014 at 2:16 AM, Steve Loughran <stevel@hortonworks.com>
> wrote:
> >
> > +1 to upgrade.
> >
> > regarding the newly surfacing issues, I'd recommend we look at them and
> see
> > which are critical problems and fix them.
> >
> > One of the conclusions I got from the building is that there are a lot =
of
> > javac and javadoc warnings  that everyone ignores. Sitting down to fix
> them
> > is time consuming and doesn't directly fix anything or add new features
> > =E2=80=94but it keeps the code cleaner, which is something we want to e=
ncourage
> >
> > --
> > CONFIDENTIALITY NOTICE
> > NOTICE: This message is intended for the use of the individual or entit=
y
> to
> > which it is addressed and may contain information that is confidential,
> > privileged and exempt from disclosure under applicable law. If the read=
er
> > of this message is not the intended recipient, you are hereby notified
> that
> > any printing, copying, dissemination, distribution, disclosure or
> > forwarding of this communication is strictly prohibited. If you have
> > received this communication in error, please contact the sender
> immediately
> > and delete it from your system. Thank You.
> >
>
> --
> CONFIDENTIALITY NOTICE
> NOTICE: This message is intended for the use of the individual or entity =
to
> which it is addressed and may contain information that is confidential,
> privileged and exempt from disclosure under applicable law. If the reader
> of this message is not the intended recipient, you are hereby notified th=
at
> any printing, copying, dissemination, distribution, disclosure or
> forwarding of this communication is strictly prohibited. If you have
> received this communication in error, please contact the sender immediate=
ly
> and delete it from your system. Thank You.
>


--=20
Zhijie Shen
Hortonworks Inc.
http://hortonworks.com/

--=20
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to=
=20
which it is addressed and may contain information that is confidential,=20
privileged and exempt from disclosure under applicable law. If the reader=
=20
of this message is not the intended recipient, you are hereby notified that=
=20
any printing, copying, dissemination, distribution, disclosure or=20
forwarding of this communication is strictly prohibited. If you have=20
received this communication in error, please contact the sender immediately=
=20
and delete it from your system. Thank You.

--001a11c2d7d4a835fb050b5ef8f1--