hadoop-yarn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ted Yu <yuzhih...@gmail.com>
Subject Re: Documentation change causing Findbug warnings?
Date Fri, 19 Dec 2014 18:28:10 GMT
My understanding is that as long as your changes don't introduce new findbug
warnings, your patch is ready for review.

Cheers

On Fri, Dec 19, 2014 at 10:00 AM, Bhat, Vijay (CONT) <
Vijay.Bhat@capitalone.com> wrote:
>
> I did a search and see that there is an open JIRA in progress for fixing
> the new findbug warnings.
>
> https://issues.apache.org/jira/browse/HADOOP-11370
>
>
> Does this mean I need to wait till this issue is resolved and my patch
> fully passes the pre-commit build before it can be reviewed / merged into
> trunk? I am new to the Hadoop contribution process, so apologies in
> advance if this is a n00b question.
>
> Thanks,
> Vijay
>
> On 12/18/14, 5:13 PM, "Ted Yu" <yuzhihong@gmail.com> wrote:
>
> >For build #6152, you would find the warnings listed in this file:
> >
> https://builds.apache.org/job/PreCommit-YARN-Build/6152/artifact/patchproc
> >ess/newPatchFindbugsWarningshadoop-yarn-common.html
> >
> >My guess is that the 25 warnings were introduced by some other JIRA.
> >
> >Cheers
> >
> >On Thu, Dec 18, 2014 at 4:42 PM, Bhat, Vijay (CONT) <
> >Vijay.Bhat@capitalone.com> wrote:
> >>
> >> I¹ve uploaded a patch that modifies the description text in
> >> yarn-default.xml. Jenkins as well as dev-support/test-patch.sh are
> >> claiming that the patch is introducing 25 new Findbug warnings. Any
> >>ideas
> >> how that is possible?
> >>
> >> When I run the Findbugs command (from test-patch.sh) on Hadoop trunk
> >> without my patch, I still get the same Findbug warnings.
> >>
> >> mvn clean test findbugs:findbugs -DskipTests -DHadoopPatchProcess <
> >> /dev/null
> >>
> >>
> >> Any insight much appreciated!
> >>
> >> Thanks,
> >> Vijay
> >>
> >>
> >> On 12/18/14, 4:05 PM, "Apache Jenkins Server"
> >><jenkins@builds.apache.org>
> >> wrote:
> >>
> >> >Jira: https://issues.apache.org/jira/browse/YARN-2230
> >> >Build: https://builds.apache.org/job/PreCommit-YARN-Build/6152/
> >> >
> >>
> >>>########################################################################
> >>>##
> >> >#########
> >> >########################## LAST 60 LINES OF THE CONSOLE
> >> >###########################
> >> >[...truncated 3201 lines...]
> >> >
> >> >
> >> >{color:red}-1 overall{color}.  Here are the results of testing the
> >>latest
> >> >attachment
> >> >
> >> >
> >>
> >>
> http://issues.apache.org/jira/secure/attachment/12688178/YARN-2230.001.pa
> >>t
> >> >ch
> >> >  against trunk revision 0402bad.
> >> >
> >> >    {color:green}+1 @author{color}.  The patch does not contain any
> >> >@author tags.
> >> >
> >> >    {color:green}+0 tests included{color}.  The patch appears to be a
> >> >documentation patch that doesn't require tests.
> >> >
> >> >    {color:green}+1 javac{color}.  The applied patch does not increase
> >> >the total number of javac compiler warnings.
> >> >
> >> >    {color:green}+1 javadoc{color}.  There were no new javadoc warning
> >> >messages.
> >> >
> >> >    {color:green}+1 eclipse:eclipse{color}.  The patch built with
> >> >eclipse:eclipse.
> >> >
> >> >    {color:red}-1 findbugs{color}.  The patch appears to introduce 25
> >>new
> >> >Findbugs (version 2.0.3) warnings.
> >> >
> >> >    {color:green}+1 release audit{color}.  The applied patch does not
> >> >increase the total number of release audit warnings.
> >> >
> >> >    {color:green}+1 core tests{color}.  The patch passed unit tests in
> >> >hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
> >> >
> >> >Test results:
> >> >https://builds.apache.org/job/PreCommit-YARN-Build/6152//testReport/
> >> >Findbugs warnings:
> >> >
> >>
> >>
> https://builds.apache.org/job/PreCommit-YARN-Build/6152//artifact/patchpr
> >>o
> >> >cess/newPatchFindbugsWarningshadoop-yarn-common.html
> >> >Console output:
> >> >https://builds.apache.org/job/PreCommit-YARN-Build/6152//console
> >> >
> >> >This message is automatically generated.
> >> >
> >> >
> >> >======================================================================
> >> >======================================================================
> >> >    Adding comment to Jira.
> >> >======================================================================
> >> >======================================================================
> >> >
> >> >
> >> >Comment added.
> >> >f32fb9d0063b14670bd9d0674c5aba43dd4b1459 logged out
> >> >
> >> >
> >> >======================================================================
> >> >======================================================================
> >> >    Finished build.
> >> >======================================================================
> >> >======================================================================
> >> >
> >> >
> >> >Build step 'Execute shell' marked build as failure
> >> >Archiving artifacts
> >> >Sending artifact delta relative to PreCommit-YARN-Build #6051
> >> >Archived 15 artifacts
> >> >Archive block size is 32768
> >> >Received 154 blocks and 3870626 bytes
> >> >Compression is 56.6%
> >> >Took 2.5 sec
> >> >[description-setter] Could not determine description.
> >> >Recording test results
> >> >Email was triggered for: Failure
> >> >Sending email for trigger: Failure
> >> >
> >> >
> >> >
> >>
> >>>########################################################################
> >>>##
> >> >#########
> >> >############################## FAILED TESTS (if any)
> >> >##############################
> >> >All tests passed
> >>
> >> ________________________________________________________
> >>
> >> The information contained in this e-mail is confidential and/or
> >> proprietary to Capital One and/or its affiliates. The information
> >> transmitted herewith is intended only for use by the individual or
> >>entity
> >> to which it is addressed.  If the reader of this message is not the
> >> intended recipient, you are hereby notified that any review,
> >> retransmission, dissemination, distribution, copying or other use of, or
> >> taking of any action in reliance upon this information is strictly
> >> prohibited. If you have received this communication in error, please
> >> contact the sender and delete the material from your computer.
> >>
> >>
>
> ________________________________________________________
>
> The information contained in this e-mail is confidential and/or
> proprietary to Capital One and/or its affiliates. The information
> transmitted herewith is intended only for use by the individual or entity
> to which it is addressed.  If the reader of this message is not the
> intended recipient, you are hereby notified that any review,
> retransmission, dissemination, distribution, copying or other use of, or
> taking of any action in reliance upon this information is strictly
> prohibited. If you have received this communication in error, please
> contact the sender and delete the material from your computer.
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message