hadoop-yarn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Created] (YARN-872) BlockDecompressorStream#decompress will throw EOFException instead of return -1 when EOF
Date Fri, 21 Jun 2013 20:44:21 GMT
Zhijie Shen created YARN-872:
--------------------------------

             Summary: BlockDecompressorStream#decompress will throw EOFException instead of
return -1 when EOF
                 Key: YARN-872
                 URL: https://issues.apache.org/jira/browse/YARN-872
             Project: Hadoop YARN
          Issue Type: Bug
            Reporter: Zhijie Shen
            Assignee: Zhijie Shen
            Priority: Critical


BlockDecompressorStream#decompress ultimately calls rawReadInt, which will throw EOFException
instead of return -1 when encountering end of a stream. Then, decompress will be called by
read. However, InputStream#read is supposed to return -1 instead of throwing EOFException
to indicate the end of a stream. This explains why in LineReader,
{code}
      if (bufferPosn >= bufferLength) {
        startPosn = bufferPosn = 0;
        if (prevCharCR)
          ++bytesConsumed; //account for CR from previous read
        bufferLength = in.read(buffer);
        if (bufferLength <= 0)
          break; // EOF
      }
{code}
-1 is checked instead of catching EOFException.

Now the problem will occur with SnappyCodec. If an input file is compressed with SnappyCodec,
it needs to be decompressed through BlockDecompressorStream when it is read. Then, if it empty,
EOFException will been thrown from rawReadInt and break LineReader.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message