Return-Path: X-Original-To: apmail-hadoop-yarn-dev-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4DD36DCB1 for ; Wed, 26 Sep 2012 17:31:49 +0000 (UTC) Received: (qmail 57309 invoked by uid 500); 26 Sep 2012 17:31:46 -0000 Delivered-To: apmail-hadoop-yarn-dev-archive@hadoop.apache.org Received: (qmail 57037 invoked by uid 500); 26 Sep 2012 17:31:46 -0000 Mailing-List: contact yarn-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-dev@hadoop.apache.org Delivered-To: mailing list yarn-dev@hadoop.apache.org Received: (qmail 57014 invoked by uid 99); 26 Sep 2012 17:31:46 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Sep 2012 17:31:46 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [209.85.160.48] (HELO mail-pb0-f48.google.com) (209.85.160.48) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Sep 2012 17:31:39 +0000 Received: by pbcwy7 with SMTP id wy7so1155425pbc.35 for ; Wed, 26 Sep 2012 10:31:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :message-id:references:to:x-mailer:x-gm-message-state; bh=RQA66UJ0y+5XkQxkenfuVDOE7qk1BM6z/8vgMxr6h7o=; b=SRKlSZpD3a5woh71Uvm5DZKg4hg9hb4OhbK955u6rZktrRlHSFGsgtdUQNOePA0BQS em1aQ9qTvEOif7nhlC6oH+mSKd/6pFAkddLpZ2+itP2PPc/h+zHIXmY+obRiiUrUF1jT z2Q3CN+yGKw/9P2bB6ajPtSzl84+rJWjWQvu2Ze1hwfSrr/7Krvvm5OY2l33ly895NPi yPNW3iJ91gdMhSiHZMSeTK/LlwZl5UG0jgVb8BRZZzg+Mhtyq03Mu8vY6GgJDt15gnPw Hzhj/UWAdVfAuEtNyA7/EmIDgOe6XA/jIBtzTva47lPffhr47aAXrVzcu8AErVFDu29k NH8g== Received: by 10.66.83.8 with SMTP id m8mr3001517pay.48.1348680679206; Wed, 26 Sep 2012 10:31:19 -0700 (PDT) Received: from [10.10.11.96] (host1.hortonworks.com. [70.35.59.2]) by mx.google.com with ESMTPS id ky6sm2369525pbc.18.2012.09.26.10.31.08 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 26 Sep 2012 10:31:18 -0700 (PDT) Subject: Re: Commits breaking compilation of MR 'classic' tests Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: multipart/alternative; boundary=Apple-Mail-924-1006280588 From: Arun C Murthy In-Reply-To: Date: Wed, 26 Sep 2012 10:31:07 -0700 Cc: common-dev@hadoop.apache.org, yarn-dev@hadoop.apache.org, mapreduce-dev@hadoop.apache.org Message-Id: References: To: hdfs-dev@hadoop.apache.org, Robert Evans X-Mailer: Apple Mail (2.1084) X-Gm-Message-State: ALoCoQnH4Li1cTtevgVkjB+vX8R8S2d14ujVN4b3akTSx9lweccUf5YUuC29R6mUxQKParCx6yrc X-Virus-Checked: Checked by ClamAV on apache.org --Apple-Mail-924-1006280588 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Fair, however there are still tests which need to be ported over. We can = remove them after the port. On Sep 26, 2012, at 9:54 AM, Robert Evans wrote: > As per my comment on the bug. I though we were going to remove them. >=20 > MAPREDUCE-4266 only needs a little bit more work, change a patch to a > script, before they disappear entirely. I would much rather see dead = code > die then be maintained for a few tests that are mostly testing the = dead > code itself. >=20 >=20 > --Bobby >=20 > On 9/26/12 9:39 AM, "Arun C Murthy" wrote: >=20 >> Point. I've opened = https://issues.apache.org/jira/browse/MAPREDUCE-4687 >> to track this. >>=20 >> On Sep 25, 2012, at 9:33 PM, Eli Collins wrote: >>=20 >>> How about adding this step to the MR PreCommit jenkins job so it's = run >>> as part test-patch? >>>=20 >>> On Tue, Sep 25, 2012 at 7:48 PM, Arun C Murthy >>> wrote: >>>> Committers, >>>>=20 >>>> As most people are aware, the MapReduce 'classic' tests (in >>>> hadoop-mapreduce-project/src/test) still need to built using ant = since >>>> they aren't mavenized yet. >>>>=20 >>>> I've seen several commits (and 2 within the last hour i.e. >>>> MAPREDUCE-3681 and MAPREDUCE-3682) which lead me to believe >>>> developers/committers aren't checking for this. >>>>=20 >>>> Henceforth, with all changes, before committing, please do run: >>>> $ mvn install >>>> $ cd hadoop-mapreduce-project >>>> $ ant veryclean all-jars -Dresolvers=3Dinternal >>>>=20 >>>> These instructions were already in >>>> http://wiki.apache.org/hadoop/HowToReleasePostMavenization and I've >>>> just updated http://wiki.apache.org/hadoop/HowToContribute. >>>>=20 >>>> thanks, >>>> Arun >>>>=20 >>=20 >> -- >> Arun C. Murthy >> Hortonworks Inc. >> http://hortonworks.com/ >>=20 >>=20 >=20 -- Arun C. Murthy Hortonworks Inc. http://hortonworks.com/ --Apple-Mail-924-1006280588--