hadoop-yarn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Arun C Murthy <...@hortonworks.com>
Subject Re: Commits breaking compilation of MR 'classic' tests
Date Wed, 26 Sep 2012 17:31:07 GMT
Fair, however there are still tests which need to be ported over. We can remove them after
the port.

On Sep 26, 2012, at 9:54 AM, Robert Evans wrote:

> As per my comment on the bug.  I though we were going to remove them.
> 
> MAPREDUCE-4266 only needs a little bit more work, change a patch to a
> script, before they disappear entirely.  I would much rather see dead code
> die then be maintained for a few tests that are mostly testing the dead
> code itself.
> 
> 
> --Bobby
> 
> On 9/26/12 9:39 AM, "Arun C Murthy" <acm@hortonworks.com> wrote:
> 
>> Point. I've opened https://issues.apache.org/jira/browse/MAPREDUCE-4687
>> to track this.
>> 
>> On Sep 25, 2012, at 9:33 PM, Eli Collins wrote:
>> 
>>> How about adding this step to the MR PreCommit jenkins job so it's run
>>> as part test-patch?
>>> 
>>> On Tue, Sep 25, 2012 at 7:48 PM, Arun C Murthy <acm@hortonworks.com>
>>> wrote:
>>>> Committers,
>>>> 
>>>> As most people are aware, the MapReduce 'classic' tests (in
>>>> hadoop-mapreduce-project/src/test) still need to built using ant since
>>>> they aren't mavenized yet.
>>>> 
>>>> I've seen several commits (and 2 within the last hour i.e.
>>>> MAPREDUCE-3681 and MAPREDUCE-3682) which lead me to believe
>>>> developers/committers aren't checking for this.
>>>> 
>>>> Henceforth, with all changes, before committing, please do run:
>>>> $ mvn install
>>>> $ cd hadoop-mapreduce-project
>>>> $ ant veryclean all-jars -Dresolvers=internal
>>>> 
>>>> These instructions were already in
>>>> http://wiki.apache.org/hadoop/HowToReleasePostMavenization and I've
>>>> just updated http://wiki.apache.org/hadoop/HowToContribute.
>>>> 
>>>> thanks,
>>>> Arun
>>>> 
>> 
>> --
>> Arun C. Murthy
>> Hortonworks Inc.
>> http://hortonworks.com/
>> 
>> 
> 

--
Arun C. Murthy
Hortonworks Inc.
http://hortonworks.com/



Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message