Return-Path: X-Original-To: apmail-hadoop-yarn-commits-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1E38C114AC for ; Tue, 24 Jun 2014 13:58:36 +0000 (UTC) Received: (qmail 22779 invoked by uid 500); 24 Jun 2014 13:58:36 -0000 Delivered-To: apmail-hadoop-yarn-commits-archive@hadoop.apache.org Received: (qmail 22743 invoked by uid 500); 24 Jun 2014 13:58:36 -0000 Mailing-List: contact yarn-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-commits@hadoop.apache.org Delivered-To: mailing list yarn-commits@hadoop.apache.org Received: (qmail 22732 invoked by uid 99); 24 Jun 2014 13:58:35 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jun 2014 13:58:35 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jun 2014 13:58:34 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id A5656238889B; Tue, 24 Jun 2014 13:58:14 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1605085 - in /hadoop/common/branches/branch-2/hadoop-yarn-project: CHANGES.txt hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceRequest.java Date: Tue, 24 Jun 2014 13:58:14 -0000 To: yarn-commits@hadoop.apache.org From: devaraj@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20140624135814.A5656238889B@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: devaraj Date: Tue Jun 24 13:58:14 2014 New Revision: 1605085 URL: http://svn.apache.org/r1605085 Log: YARN-2195. Clean a piece of code in ResourceRequest. Contributed by Wei Yan. Modified: hadoop/common/branches/branch-2/hadoop-yarn-project/CHANGES.txt hadoop/common/branches/branch-2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceRequest.java Modified: hadoop/common/branches/branch-2/hadoop-yarn-project/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-2/hadoop-yarn-project/CHANGES.txt?rev=1605085&r1=1605084&r2=1605085&view=diff ============================================================================== --- hadoop/common/branches/branch-2/hadoop-yarn-project/CHANGES.txt (original) +++ hadoop/common/branches/branch-2/hadoop-yarn-project/CHANGES.txt Tue Jun 24 13:58:14 2014 @@ -158,6 +158,8 @@ Release 2.5.0 - UNRELEASED YARN-2191. Added a new test to ensure NM will clean up completed applications in the case of RM restart. (Wangda Tan via jianhe) + YARN-2195. Clean a piece of code in ResourceRequest. (Wei Yan via devaraj) + OPTIMIZATIONS BUG FIXES Modified: hadoop/common/branches/branch-2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceRequest.java URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceRequest.java?rev=1605085&r1=1605084&r2=1605085&view=diff ============================================================================== --- hadoop/common/branches/branch-2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceRequest.java (original) +++ hadoop/common/branches/branch-2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceRequest.java Tue Jun 24 13:58:14 2014 @@ -296,13 +296,7 @@ public abstract class ResourceRequest im int capabilityComparison = this.getCapability().compareTo(other.getCapability()); if (capabilityComparison == 0) { - int numContainersComparison = - this.getNumContainers() - other.getNumContainers(); - if (numContainersComparison == 0) { - return 0; - } else { - return numContainersComparison; - } + return this.getNumContainers() - other.getNumContainers(); } else { return capabilityComparison; }