Return-Path: X-Original-To: apmail-hadoop-user-archive@minotaur.apache.org Delivered-To: apmail-hadoop-user-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 54F25E6EA for ; Mon, 11 Feb 2013 07:41:50 +0000 (UTC) Received: (qmail 56364 invoked by uid 500); 11 Feb 2013 07:41:45 -0000 Delivered-To: apmail-hadoop-user-archive@hadoop.apache.org Received: (qmail 56074 invoked by uid 500); 11 Feb 2013 07:41:44 -0000 Mailing-List: contact user-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@hadoop.apache.org Delivered-To: mailing list user@hadoop.apache.org Received: (qmail 56048 invoked by uid 99); 11 Feb 2013 07:41:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Feb 2013 07:41:44 +0000 X-ASF-Spam-Status: No, hits=-0.5 required=5.0 tests=FREEMAIL_ENVFROM_END_DIGIT,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of donofrio111@gmail.com designates 209.85.128.182 as permitted sender) Received: from [209.85.128.182] (HELO mail-ve0-f182.google.com) (209.85.128.182) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Feb 2013 07:41:36 +0000 Received: by mail-ve0-f182.google.com with SMTP id ox1so4930788veb.27 for ; Sun, 10 Feb 2013 23:41:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=vMWhSHedb6PWh++7kZ8/KRXyVcwPSYUIE01NEpw4qN4=; b=vzao7arZr0r6bDUHNSgZfo8NBeuSxV7DfdhOvlz0hRNAE7H9lVxY50wZ+UmO7c0SHr sG9h0w4AxeVVz5Hxny0z+dlQaZQ6liZ5lK2AexndGh8cbRe0J2gq2gTLfLgbDRO8W4d3 qDrp4UlunlcJmHceSjYWvRIU8u4eiALEorxI5BBMYaXQ1KAjjRKLLYQRVaYUUFCDxJCh LeFLad5vzw1mmWhJoIJvzBLdSvuVZCYmuKdC6sy7N6rozmHHBKlTgW1cE6PRjSLBcXY2 ogLIvN3YkDLtVEqV1e8QkCdCLzLzlJap3tthLkSxFqTW/n/CTr91tJHGDh0moHZce2n/ JOBA== X-Received: by 10.58.161.41 with SMTP id xp9mr17343791veb.56.1360568475263; Sun, 10 Feb 2013 23:41:15 -0800 (PST) Received: from [192.168.0.3] (c-68-55-55-92.hsd1.md.comcast.net. [68.55.55.92]) by mx.google.com with ESMTPS id p20sm58403914vdj.6.2013.02.10.23.41.13 (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 10 Feb 2013 23:41:14 -0800 (PST) Message-ID: <5118A088.5040407@gmail.com> Date: Mon, 11 Feb 2013 02:40:56 -0500 From: Jim Donofrio User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: user@hadoop.apache.org Subject: Re: why does OldCombinerRunner pass Reporter.NULL to the combiner instead of the real reporter? References: <5113AEC8.6000208@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org I submitted MAPREDUCE-4998 with a patch On 02/07/2013 11:18 AM, Harsh J wrote: > I agree its a bug if there is a discrepancy between the APIs (we are > supposed to be supporting both for the time being). Please do file a > JIRA with a patch - there shouldn't be any harm in re-passing the > reporter object within the combiner. > > On Thu, Feb 7, 2013 at 7:10 PM, Jim Donofrio wrote: >> Is there a good reason why the OldCombinerRunner passes Reporter.NULL to the >> combiner instead of the actual TaskReporter? The NewCombinerRunner does use >> the TaskReporter when creating the context. If this is a bug I will submit a >> JIRA with a patch > > > -- > Harsh J >