Return-Path: X-Original-To: apmail-hadoop-user-archive@minotaur.apache.org Delivered-To: apmail-hadoop-user-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F26C2D1CE for ; Tue, 7 Aug 2012 15:44:42 +0000 (UTC) Received: (qmail 98532 invoked by uid 500); 7 Aug 2012 15:44:37 -0000 Delivered-To: apmail-hadoop-user-archive@hadoop.apache.org Received: (qmail 98399 invoked by uid 500); 7 Aug 2012 15:44:37 -0000 Mailing-List: contact user-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@hadoop.apache.org Delivered-To: mailing list user@hadoop.apache.org Received: (qmail 98392 invoked by uid 99); 7 Aug 2012 15:44:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Aug 2012 15:44:37 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=FSL_RCVD_USER,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [209.85.213.48] (HELO mail-yw0-f48.google.com) (209.85.213.48) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Aug 2012 15:44:32 +0000 Received: by yhfq46 with SMTP id q46so4507058yhf.35 for ; Tue, 07 Aug 2012 08:44:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-originating-ip:in-reply-to:references:date :message-id:subject:from:to:content-type:x-gm-message-state; bh=ehKQjqxMLs9v1EYFA9ssoaak6iV1lLBzvYmBercV8Ec=; b=MgDxBIGgdALHnwcdDZRY9+H2AqZ5V+LcyzU0BBnEEliHu7nX/8yH3IADHB/Kvkn0SS ZYPe+YJUPtzvl9Gr4hYqJdn+n2VHh+8Kg7TBAAPGwTKclir2y0DUgpnauKtp3Yk/fU3W x2a/aGlajLjtavgE6/QR6HZ+NGpotHubeVsxGWaBUPy166i2+/spBkRv27whtrdEEO5e BsxLEK7UOZqmEBftpQAs4fbExgpy8PMFTOVMgQkbIMHHoFdDg43o0viQPjhhBIar3bda zPq5U5tpE2gcmJMzrKwHw+wdQbDMFA//dmKdLoh0nhbEOoAMcdEPGyIZShdEQ6HhSK71 jMNw== MIME-Version: 1.0 Received: by 10.50.220.225 with SMTP id pz1mr6303353igc.42.1344354251075; Tue, 07 Aug 2012 08:44:11 -0700 (PDT) Received: by 10.231.23.68 with HTTP; Tue, 7 Aug 2012 08:44:11 -0700 (PDT) X-Originating-IP: [96.10.173.94] In-Reply-To: References: <1DA607DA-E9D9-43E5-B93F-654C1AA090BE@yahoo-inc.com> Date: Tue, 7 Aug 2012 11:44:11 -0400 Message-ID: Subject: Re: fs cache giving me headaches From: Koert Kuipers To: user@hadoop.apache.org Content-Type: multipart/alternative; boundary=f46d043c06b6966e7104c6aedd0d X-Gm-Message-State: ALoCoQkxcxaC6mPhQRmT8f4HMpmxEj1M34L8QSNs19tzCqujc3H/xyH0vrskhbOdUx/Md8B1o8rB X-Virus-Checked: Checked by ClamAV on apache.org --f46d043c06b6966e7104c6aedd0d Content-Type: text/plain; charset=ISO-8859-1 I am a little confused.... I do create new ugis, and i do not hand them off to threads. However i assumed that FileSystem.get(conf) would fetch from the filesystem cache based on the ugi (based on equality that is, not identity). So my assumption was that if different threads create ugis that are equal, they would fetch the same FileSystem from the cache. Is that wrong? On Tue, Aug 7, 2012 at 11:25 AM, Daryn Sharp wrote: > There is no UGI caching, so each request will receive a unique UGI even > for the same user. Thus you can safely call FileSystem.closeAllForUGI(ugi) > when the request is complete. If however you spin off threads that > continue to use the UGI even after the request is completed, then you'll > have to determine for yourself when it's safe to close the filesystems. > > I've been kicking around a few ways to transparently close cached > filesystems for a ugi when that ugi goes out of scope. I should probably > file a jira (if it stops going down) for discussion. > > Daryn > > > On Aug 7, 2012, at 10:15 AM, Koert Kuipers wrote: > > Daryn, > The problem with FileSystem.closeAllForUGI(ugi) for me is that a server > can be multi-threaded, and a user could be doing multiple request at the > same time, so if i used closeAllForUGI isn't there a risk of shutting down > the other requests for the same user? > > On Mon, Aug 6, 2012 at 2:52 PM, Daryn Sharp wrote: > >> Yes, the implementation of fs.close() leaves something to be desired. >> There's actually been debate in the past about close being a no-op for a >> cached fs, but the idea was rejected by the majority of people. >> >> In the server case, you can use FileSystem.closeAllForUGI(ugi) at the end >> of a request to flush all the fs cache entries for the ugi. You'll get the >> benefit of the cache during execution of the request, and be able to close >> the cached fs instances to prevent memory leaks. I hope this helps! >> >> Daryn >> >> >> On Aug 6, 2012, at 12:32 PM, Koert Kuipers wrote: >> >> ---------- Forwarded message ---------- >> From: "Koert Kuipers" >> Date: Aug 4, 2012 1:54 PM >> Subject: fs cache giving me headaches >> To: >> >> nothing has confused me as much in hadoop as FileSystem.close(). >> any decent java programmer that sees that an object implements Closable >> writes code like this: >> Final FileSystem fs = FileSystem.get(conf); >> try { >> // do something with fs >> } finally { >> fs.close(); >> } >> >> so i started out using hadoop FileSystem like this, and i ran into all >> sorts of weird errors where FileSystems in unrelated code (sometimes not >> even my code) started misbehaving and streams where unexpectedly shut. Then >> i realized that FileSystem uses a cache and close() closes it for everyone! >> Not pretty in my opinion, but i can live with it. So i checked other code >> and found that basically nobody closes FileSystems. Apparently the expected >> way of using FileSystems is to simple never close them. So i adopted this >> approach (which i think is really contrary to java conventions for a >> Closeable). >> >> Lately i started working on some code for a daemon/server where many >> FileSystems objects are created for different users (UGIs) that use the >> service. As it turns out other projects have run into trouble with the >> FileSystem cache in situations like this (for example, Scribe and Hoop). I >> imagine the cache can get very large and cause problems (i have not tested >> this myself). >> >> Looking at the code for Hoop i noticed they simply turned off the >> FileSystem cache and made sure to close every FileSystem. So here the >> suggested approach to deal with FileSystems seems to be: >> Final FileSystem fs = FileSystem.newInstance(conf); // or >> FileSystem.get(conf) but with caching turned off in the conf >> try { >> // do something with fs >> } finally { >> fs.close(); >> } >> >> This code bypasses the cache if i understand it correctly, avoiding any >> cache size limitations. However if i adopt this approach i basically can >> not re-use any existing code or libraries that do not close FileSystems, >> splitting the codebase into two which is pretty ugly. And this code is not >> efficient in situations where there are very few used FileSystem objects >> and a cache would improve performance, so the split works both ways. >> >> In short, there is so single way to code with FileSystem that works in >> both situations! Ideally i would have liked fs.close() to do the right >> thing depending in the settings: if cache is turned off it closes the >> FileSystem, and if it is turned on its a NOOP. That way i could always use >> FileSystem.get(conf) and always close my filesystems, and the code would be >> usable irrespective of whether the cache is turned on or off. >> >> Any insights or suggestions? Thanks! >> >> >> > > --f46d043c06b6966e7104c6aedd0d Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable I am a little confused....
I do create new ugis, and i do not hand them = off to threads. However i assumed that FileSystem.get(conf) would fetch fro= m the filesystem cache based on the ugi (based on equality that is, not ide= ntity). So my assumption was that if different threads create ugis that are= equal, they would fetch the same FileSystem from the cache. Is that wrong?=

On Tue, Aug 7, 2012 at 11:25 AM, Daryn Sharp= <daryn@yahoo-inc.com> wrote:
There is no UGI caching, so each reques= t will receive a unique UGI even for the same user. =A0Thus you can safely = call=A0FileSystem.closeAllForUGI(ugi) when the request is complete. =A0If h= owever you spin off threads that continue to use the UGI even after the req= uest is completed, then you'll have to determine for yourself when it&#= 39;s safe to close the filesystems.

I've been kicking around a few ways to transparently clo= se cached filesystems for a ugi when that ugi goes out of scope. =A0I shoul= d probably file a jira (if it stops going down) for discussion.

Daryn

On Aug 7, 2012, at 10:15 AM, Koert Kuipers wrote:

Daryn,
The problem with FileSystem.closeAllForUG= I(ugi) for me is that a server can be multi-threaded, and a user could be d= oing multiple request at the same time, so if i used closeAllForUGI isn'= ;t there a risk of shutting down the other requests for the same user?

On Mon, Aug 6, 2012 at 2:52 PM, Daryn Sharp = <daryn@yahoo-inc.com> wrote:
Yes, the implementation of fs.close() l= eaves something to be desired. =A0There's actually been debate in the p= ast about close being a no-op for a cached fs, but the idea was rejected by= the majority of people.

In the server case, you can use FileSystem.closeAllForUGI(ug= i) at the end of a request to flush all the fs cache entries for the ugi. = =A0You'll get the benefit of the cache during execution of the request,= and be able to close the cached fs instances to prevent memory leaks. I ho= pe this helps!

Daryn

On Aug 6, 2012, at 12:32 PM, Koert Kuipers wrote:

---------- Forwarded mes= sage ----------
From: "Koert Kuipers" <koert@tresata.com>
Date: Aug 4, 2012 1:54 PM
Subject: fs cache giving me headaches
To: <common-user@hadoop.apache.org>

nothing = has confused me as much in hadoop as FileSystem.close().
any decent java= programmer that sees that an object implements Closable writes code like t= his:
Final FileSystem fs =3D FileSystem.get(conf);
try {
=A0=A0=A0 // do something with fs
} finally {
=A0=A0=A0 fs.close();}

so i started out using hadoop FileSystem like this, and i ran in= to all sorts of weird errors where FileSystems in unrelated code (sometimes= not even my code) started misbehaving and streams where unexpectedly shut.= Then i realized that FileSystem uses a cache and close() closes it for eve= ryone! Not pretty in my opinion, but i can live with it. So i checked other= code and found that basically nobody closes FileSystems. Apparently the ex= pected way of using FileSystems is to simple never close them. So i adopted= this approach (which i think is really contrary to java conventions for a = Closeable).

Lately i started working on some code for a daemon/server where many Fi= leSystems objects are created for different users (UGIs) that use the servi= ce. As it turns out other projects have run into trouble with the FileSyste= m cache in situations like this (for example, Scribe and Hoop). I imagine t= he cache can get very large and cause problems (i have not tested this myse= lf).

Looking at the code for Hoop i noticed they simply turned off the FileS= ystem cache and made sure to close every FileSystem. So here the suggested = approach to deal with FileSystems seems to be:
Final FileSystem fs =3D F= ileSystem.newInstance(conf); // or FileSystem.get(conf) but with caching tu= rned off in the conf
try {
=A0=A0=A0 // do something with fs
} finally {
=A0=A0=A0 fs.close();
}

This code bypasses the cache if i understand it correctly, avoiding any= cache size limitations. However if i adopt this approach i basically can n= ot re-use any existing code or libraries that do not close FileSystems, spl= itting the codebase into two which is pretty ugly. And this code is not eff= icient in situations where there are very few used FileSystem objects and a= cache would improve performance, so the split works both ways.

In short, there is so single way to code with FileSystem that works in = both situations! Ideally i would have liked fs.close() to do the right thin= g depending in the settings: if cache is turned off it closes the FileSyste= m, and if it is turned on its a NOOP. That way i could always use FileSyste= m.get(conf) and always close my filesystems, and the code would be usable i= rrespective of whether the cache is turned on or off.

Any insights or suggestions? Thanks!



--f46d043c06b6966e7104c6aedd0d--