hadoop-submarine-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop-submarine] jiwq commented on a change in pull request #8: [SUBMARINE-181] Submarine team manager TeamRestApi
Date Tue, 24 Sep 2019 09:39:59 GMT
jiwq commented on a change in pull request #8: [SUBMARINE-181] Submarine team manager TeamRestApi
URL: https://github.com/apache/hadoop-submarine/pull/8#discussion_r327516790
 
 

 ##########
 File path: submarine-workbench/submarine-server/src/main/java/org/apache/submarine/database/entity/TeamMember.java
 ##########
 @@ -45,4 +57,17 @@ public Integer getInviter() {
   public void setInviter(Integer inviter) {
     this.inviter = inviter;
   }
+
+  @Override
+  public boolean equals(Object o) {
+    if (this == o) return true;
 
 Review comment:
   In the java guide [4.1.1](https://google.github.io/styleguide/javaguide.html#s4.1.1-braces-always-used),
this is not acceptable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message