hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Carey (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1334) Make pig artifacts available through maven
Date Mon, 16 Aug 2010 17:50:18 GMT

    [ https://issues.apache.org/jira/browse/PIG-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899007#action_12899007
] 

Scott Carey commented on PIG-1334:
----------------------------------

-1, based on the output at https://repository.apache.org/content/repositories/snapshots/org/apache/hadoop/pig/0.8.0-SNAPSHOT/

Some problems here:  

1.  There are no -sources and -javadoc jars generated.
2.  This jar is 11MB and includes a bunch of dependencies, many of which are optional:
 com.jcraft stuff, com.google stuff, and some com.sun stuff.
 It also includes,  slf4j, modkito, junit, hamcrest, etc etc etc.  Oh, and of course some
javax.servlet that will break using it in a webapp container.

In short, this is an improperly packaged maven/ivy jar.

It should have only org.apache.pig, and specify other things as dependencies.  Users can optionally
package multiple things up into one jar.    Pig can package a jar file that has all the required
dependencies in it for the command line use (pig.jar).  But the maven repo jars (pig-0.8.0.jar,
pig-0.8.0-sources.jar, and pig-0.8.0-javadoc.jar) need to be pig and pig only.

3.  Any artifacts that are not needed at runtime should not be ordinary dependencies.  Junit
must be specified as test scope, webapp stuff (javax.*) is typically 'included' scope (the
container provides it).



> Make pig artifacts available through maven
> ------------------------------------------
>
>                 Key: PIG-1334
>                 URL: https://issues.apache.org/jira/browse/PIG-1334
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Olga Natkovich
>            Assignee: niraj rai
>             Fix For: 0.8.0
>
>         Attachments: mvn-pig.patch, mvn_pig_2.patch, mvn_pig_3.patch, mvn_pig_4.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message