hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1510) Add `deepCopy` for LogicalExpressions
Date Thu, 29 Jul 2010 09:54:16 GMT

    [ https://issues.apache.org/jira/browse/PIG-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893568#action_12893568
] 

Hadoop QA commented on PIG-1510:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12450096/deepCopy.patch
  against trunk revision 980276.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 2 new Findbugs warnings.

    -1 release audit.  The applied patch generated 435 release audit warnings (more than the
trunk's current 406 warnings).

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/384/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/384/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/384/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/384/console

This message is automatically generated.

> Add `deepCopy` for LogicalExpressions
> -------------------------------------
>
>                 Key: PIG-1510
>                 URL: https://issues.apache.org/jira/browse/PIG-1510
>             Project: Pig
>          Issue Type: New Feature
>          Components: data
>    Affects Versions: 0.8.0
>            Reporter: Swati Jain
>            Assignee: Swati Jain
>             Fix For: 0.8.0
>
>         Attachments: deepCopy.patch
>
>
> It would be useful to have a way to `deepCopy` an expression. `deepCopy` will create
a new object so that changes made to one object will not reflect in the copy. There are 2
reasons why we don't override clone.
> * It may be better to use `deepCopy` since the copy semantics are explicit (since deepCopy
may be expensive).
> * A second important reason for defining `deepCopy` as a separate routine is that it
can be passed a plan as an argument which will be updated as the expression is copied (through
plan.add and plan.connect).
> The usage would look like the following:
> {noformat}
> LogicalExpressionPlan logicalPlan = new LogicalExpressionPlan();
> LogicalExpression copyExpression = origExpression.deepCopy( logicalPlan );
> {noformat}
> An immediate motivation for this would be for constructing the expressions that constitute
the CNF form of an expression.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message