hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Russell Jurney <russell.jur...@gmail.com>
Subject Re: [jira] Commented: (PIG-1420) Make CONCAT act on all fields of a tuple, instead of just the first two fields of a tuple
Date Thu, 27 May 2010 19:09:28 GMT
Sweet!

On Thu, May 27, 2010 at 11:40 AM, Dmitriy Ryaboy <dvryaboy@gmail.com> wrote:

> No, that one is Hudson.
> While it was on, uh, medical leave, a bunch of patches got committed, so
> now
> I am guessing it's trying to apply a patch to a tree that already has said
> patch in it.
> Don't worry about it, this patch is already in trunk.
>
> -D
>
> On Thu, May 27, 2010 at 11:22 AM, Russell Jurney
> <russell.jurney@gmail.com>wrote:
>
> > Arg, I am terrible at making patches :(
> >
> > On Thu, May 27, 2010 at 5:24 AM, Hadoop QA (JIRA) <jira@apache.org>
> wrote:
> >
> > >
> > >    [
> > >
> >
> https://issues.apache.org/jira/browse/PIG-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872194#action_12872194
> > ]
> > >
> > > Hadoop QA commented on PIG-1420:
> > > --------------------------------
> > >
> > > -1 overall.  Here are the results of testing the latest attachment
> > >
> >
> http://issues.apache.org/jira/secure/attachment/12444886/addconcat2.patch
> > >  against trunk revision 948526.
> > >
> > >    +1 @author.  The patch does not contain any @author tags.
> > >
> > >    +1 tests included.  The patch appears to include 6 new or modified
> > > tests.
> > >
> > >    -1 patch.  The patch command could not apply the patch.
> > >
> > > Console output:
> > >
> >
> http://hudson.zones.apache.org/hudson/job/Pig-Patch-h1.grid.sp2.yahoo.net/5/console
> > >
> > > This message is automatically generated.
> > >
> > > > Make CONCAT act on all fields of a tuple, instead of just the first
> two
> > > fields of a tuple
> > > >
> > >
> >
> -----------------------------------------------------------------------------------------
> > > >
> > > >                 Key: PIG-1420
> > > >                 URL: https://issues.apache.org/jira/browse/PIG-1420
> > > >             Project: Pig
> > > >          Issue Type: Improvement
> > > >          Components: impl
> > > >    Affects Versions: 0.8.0
> > > >            Reporter: Russell Jurney
> > > >            Assignee: Russell Jurney
> > > >             Fix For: 0.8.0
> > > >
> > > >         Attachments: addconcat2.patch
> > > >
> > > >   Original Estimate: 24h
> > > >  Remaining Estimate: 24h
> > > >
> > > > org.apache.pig.builtin.CONCAT (which acts on DataByteArray's
> > internally)
> > > and org.apache.pig.builtin.StringConcat (which acts on Strings
> > internally),
> > > both act on the first two fields of a tuple.  This results in ugly
> nested
> > > CONCAT calls like:
> > > > CONCAT(CONCAT(A, ' '), B)
> > > > The more desirable form is:
> > > > CONCAT(A, ' ', B)
> > > > This change will be backwards compatible, provided that no one was
> > > relying on the fact that CONCAT ignores fields after the first two in a
> > > tuple.  This seems a reasonable assumption to make, or at least a small
> > > break in compatibility for a sizable improvement.
> > >
> > > --
> > > This message is automatically generated by JIRA.
> > > -
> > > You can reply to this email to add a comment to the issue online.
> > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message