hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitriy V. Ryaboy (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1420) Make CONCAT act on all fields of a tuple, instead of just the first two fields of a tuple
Date Wed, 19 May 2010 07:13:54 GMT

    [ https://issues.apache.org/jira/browse/PIG-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869033#action_12869033
] 

Dmitriy V. Ryaboy commented on PIG-1420:
----------------------------------------

Patch looks good, tests pass. I would prefer to append all the DataByteArrays at once instead
of performing multiple copies, but that's an edge optimization. Is Hudson on vacation? Haven't
heard from it in a while..

> Make CONCAT act on all fields of a tuple, instead of just the first two fields of a tuple
> -----------------------------------------------------------------------------------------
>
>                 Key: PIG-1420
>                 URL: https://issues.apache.org/jira/browse/PIG-1420
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Russell Jurney
>             Fix For: 0.7.0
>
>         Attachments: addconcat2.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> org.apache.pig.builtin.CONCAT (which acts on DataByteArray's internally) and org.apache.pig.builtin.StringConcat
(which acts on Strings internally), both act on the first two fields of a tuple.  This results
in ugly nested CONCAT calls like:
> CONCAT(CONCAT(A, ' '), B)
> The more desirable form is:
> CONCAT(A, ' ', B)
> This change will be backwards compatible, provided that no one was relying on the fact
that CONCAT ignores fields after the first two in a tuple.  This seems a reasonable assumption
to make, or at least a small break in compatibility for a sizable improvement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message