hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Russell Jurney (JIRA)" <j...@apache.org>
Subject [jira] Updated: (PIG-1420) Make CONCAT act on all fields of a tuple, instead of just the first two fields of a tuple
Date Sat, 15 May 2010 02:28:42 GMT

     [ https://issues.apache.org/jira/browse/PIG-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Russell Jurney updated PIG-1420:
--------------------------------

    Attachment: concat.patch

Patch that adds:

1) CONCAT handles all fields in the supplied tuple, instead of just the first two.
2) StringConcat handles all fields in the supplied tuple, instead of just the first two.
3) DataByteArray gets an append() to make the implementation of 1 & 2 clean (I think).
4) Unit Tests for CONCAT and StringCONCAT in TestBuiltin
5) Unit Tests for DataByteArray.append() in TestDataModel

> Make CONCAT act on all fields of a tuple, instead of just the first two fields of a tuple
> -----------------------------------------------------------------------------------------
>
>                 Key: PIG-1420
>                 URL: https://issues.apache.org/jira/browse/PIG-1420
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Russell Jurney
>             Fix For: 0.7.0
>
>         Attachments: concat.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> org.apache.pig.builtin.CONCAT (which acts on DataByteArray's internally) and org.apache.pig.builtin.StringConcat
(which acts on Strings internally), both act on the first two fields of a tuple.  This results
in ugly nested CONCAT calls like:
> CONCAT(CONCAT(A, ' '), B)
> The more desirable form is:
> CONCAT(A, ' ', B)
> This change will be backwards compatible, provided that no one was relying on the fact
that CONCAT ignores fields after the first two in a tuple.  This seems a reasonable assumption
to make, or at least a small break in compatibility for a sizable improvement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message