hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1423) Suggest to add clear command in grunt to clear the relation variable
Date Thu, 27 May 2010 22:27:39 GMT

    [ https://issues.apache.org/jira/browse/PIG-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872664#action_12872664
] 

Hadoop QA commented on PIG-1423:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12445029/PIG-1423.patch
  against trunk revision 948526.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h1.grid.sp2.yahoo.net/9/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h1.grid.sp2.yahoo.net/9/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h1.grid.sp2.yahoo.net/9/console

This message is automatically generated.

> Suggest to add clear command in grunt to clear the relation variable
> --------------------------------------------------------------------
>
>                 Key: PIG-1423
>                 URL: https://issues.apache.org/jira/browse/PIG-1423
>             Project: Pig
>          Issue Type: New Feature
>          Components: grunt
>    Affects Versions: 0.8.0
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>             Fix For: 0.8.0
>
>         Attachments: PIG-1423.patch
>
>
> The relation name in pig script can been considered as variable of programming language.
One risk of the current grunt is that user may use the previous defined relation name by typo
after a long period of work on grunt. And it is difficult for users to track this problem.
 E.g. the following red "students" is not the user intend to use, but here grunt won't throw
any error meesage.
> students = load 'a.txt';
> ....
> student = load 'b.txt';
> result = foreach {color:red}students{color} generate $0;
> The clear command is to clear the variable defined before, then if users use the relation
name defined before, grunt will throw error message. And this command also will be useful
to let user reuse the relation names especially when he's doing lots of experiments for one
specific task.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message