hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pradeep Kamath (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1419) Remove "user.name" from JobConf
Date Tue, 25 May 2010 22:21:34 GMT

    [ https://issues.apache.org/jira/browse/PIG-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871389#action_12871389
] 

Pradeep Kamath commented on PIG-1419:
-------------------------------------

+1

Minor observation in GruntParser.java:
{noformat}
565                 if (path == null) {                                                  
                                                                                         
                                                     
  566                     if (mDfs instanceof HDataStorage) {                            
                                                                                         
                                                       
  567                         container = mDfs.asContainer(((HDataStorage)mDfs).         
                                                                                         
                                                       
  568                                 getHFS().getHomeDirectory().toString());           
                                                                                         
                                                       
  569                     } else                                                         
                                                                                         
                                                       
  570                         container = mDfs.asContainer("/user/" + System.getProperty("user.name"));
       
{noformat}

Would the else ever get executed? (I think currently mDfs is always an instance of HDataStorage
right?) If this is just to make it future proof, then I am fine keeping it. Minor style comment
- would be good to enclose the else in {} even though it is a single statement - there is
another statement right below the container = ... statement - so it would be more readable
with {} block.

> Remove "user.name" from JobConf
> -------------------------------
>
>                 Key: PIG-1419
>                 URL: https://issues.apache.org/jira/browse/PIG-1419
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.7.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1419-1.patch
>
>
> In hadoop security, hadoop will use kerberos id instead of unix id. Pig should not set
"user.name" entry in jobconf. This should be decided by hadoop.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message