hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Zhang (JIRA)" <j...@apache.org>
Subject [jira] Updated: (PIG-1422) Duplicate code in LOPrinter.java
Date Thu, 20 May 2010 04:49:53 GMT

     [ https://issues.apache.org/jira/browse/PIG-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jeff Zhang updated PIG-1422:
----------------------------

    Attachment: PIG_1422.patch

Attach the patch for removing the duplicate code

> Duplicate code in LOPrinter.java
> --------------------------------
>
>                 Key: PIG-1422
>                 URL: https://issues.apache.org/jira/browse/PIG-1422
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>            Priority: Minor
>             Fix For: 0.8.0
>
>         Attachments: PIG_1422.patch
>
>
> Today when I go through the source code , I find the following duplicate code in LOPrinter.java
 (line 153 --- line 170)
> {code}
>            else if(node instanceof LOJoin){
>                 MultiMap<LogicalOperator, LogicalPlan> plans = ((LOJoin)node).getJoinPlans();
>                 for (LogicalOperator lo : plans.keySet()) {
>                     // Visit the associated plans
>                     for (LogicalPlan plan : plans.get(lo)) {
>                         sb.append(planString(plan));
>                     }
>                 }
>             }
>             else if(node instanceof LOJoin){
>                 MultiMap<LogicalOperator, LogicalPlan> plans = ((LOJoin)node).getJoinPlans();
>                 for (LogicalOperator lo : plans.keySet()) {
>                     // Visit the associated plans
>                     for (LogicalPlan plan : plans.get(lo)) {
>                         sb.append(planString(plan));
>                     }
>                 }
>             }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message