hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas M Nair (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1391) pig unit tests leave behind files in temp directory because MiniCluster files don't get deleted
Date Mon, 26 Apr 2010 16:01:37 GMT

    [ https://issues.apache.org/jira/browse/PIG-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860967#action_12860967
] 

Thejas M Nair commented on PIG-1391:
------------------------------------

bq. @Thejas : Ok, I get it now. It makes sense in this case to use the annotation.
bq. But there was one more thing that I observed in most of the test classes that extend junit.framework.TestCase.
These classes are also using either of @BeforeClass and @Test annotations. This would mean
that they are actually junit4.x compatible and need not extend junit.framework.TestCase. I'm
not sure if this should be discussed as another JIRA or can it be sorted out while working
on this issue itself?

Yes, the classes that use junit4 annotations need not extend  junit.framework.TestCase. But
if they don't extend  junit.framework.TestCase, more changes are required such as removing
the @Override for all the functions. Adding @RunWith(JUnit4.class)  to those classes seemed
to be easier. 


> pig unit tests leave behind files in temp directory because MiniCluster files don't get
deleted
> -----------------------------------------------------------------------------------------------
>
>                 Key: PIG-1391
>                 URL: https://issues.apache.org/jira/browse/PIG-1391
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Thejas M Nair
>            Assignee: Thejas M Nair
>             Fix For: 0.7.0
>
>         Attachments: minicluster.patch
>
>
> Pig unit test runs leave behind files in temp dir (/tmp) and there are too many files
in the directory over time.
> Most of the files are left behind by MiniCluster . It closes/shutsdown MiniDFSCluster,
MiniMRCluster and the FileSystem that it has created when the constructor is called, only
in finalize(). And java does not guarantee that finalize() will be called. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message