hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitriy V. Ryaboy (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1303) unable to set outgoing format for org.apache.pig.piggybank.evaluation.util.apachelogparser.DateExtractor
Date Mon, 26 Apr 2010 08:37:34 GMT

    [ https://issues.apache.org/jira/browse/PIG-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860864#action_12860864
] 

Dmitriy V. Ryaboy commented on PIG-1303:
----------------------------------------

Attached a patch for both regular UDFs and Algebraics. It's essentially what Johannes posted,
I just added a test (but see the rest of this comment), and applied the same logic to Algebraic
EvalFunc construction.

The test only really tests algebraic instantiation; I haven't been successful in reproducing
the normal instantiation problem in test mode (which is probably why it's gone undetected
so far). There's a test for it in my patch, but it's a bad one -- the test actually passes
even without the patch to the TypeCheckingVisitor.  

Johannes, could you try applying this patch and let us know if it fixes your DateExtractor
problem?

hc, this patch should unblock you for PIG-1386

> unable to set outgoing format for org.apache.pig.piggybank.evaluation.util.apachelogparser.DateExtractor
> --------------------------------------------------------------------------------------------------------
>
>                 Key: PIG-1303
>                 URL: https://issues.apache.org/jira/browse/PIG-1303
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.6.0
>         Environment: pig 0.6.0 on a fedora linux machine, jdk 1.6 u11
>            Reporter: Johannes Ru├ček
>            Assignee: Dmitriy V. Ryaboy
>             Fix For: 0.7.0, 0.8.0
>
>         Attachments: PIG-1303.patch, TypeCheckingVisitor.java.diff
>
>
> I'm unable to set the format of the outgoing date string in the constructor as it's supposed
to work. 
> The only way i could change the format was to change the default in the java class and
rebuild piggybank.
> Apparently this has something to do with the way pig instantiates DateExtractor, quoting
a replier on the mailing list:
> David Vrensk said:
> I ran into the same problem a couple of weeks ago, and
> played around with the code inserting some print/log statements.  It turns
> out that the arguments are only used in the initial constructor calls, when
> the pig process is starting, but once pig reaches the point where it would
> use the udf, it creates new DateExtractors without passing the arguments.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message