hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pradeep Kamath (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1370) Marking Pig interfaces for org.apache.pig package
Date Tue, 13 Apr 2010 17:03:56 GMT

    [ https://issues.apache.org/jira/browse/PIG-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856496#action_12856496
] 

Pradeep Kamath commented on PIG-1370:
-------------------------------------

bq. But it is accepted as an arg to one of ResourceSchema's constructors. I think that makes
it public, unless we want to say that constructor isn't intended for public use (in which
case, why is it public?).
This constructor is called from internal Pig code and we should not expose this to users -
if we don't make the constructor public we cannot call this constructor since the callers
are in different packages - I really think we need an annotation to say internal-use so we
can annotate some of the "public" methods which we don't want users to use.

bq. I did mark ComparisonFunc as deprecated. Are you saying we should just remove it instead
of deprecate it?
I think for now deprecated is fine.



> Marking Pig interfaces for org.apache.pig package
> -------------------------------------------------
>
>                 Key: PIG-1370
>                 URL: https://issues.apache.org/jira/browse/PIG-1370
>             Project: Pig
>          Issue Type: Sub-task
>          Components: documentation
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>             Fix For: 0.8.0
>
>         Attachments: PIG-1370.patch, PIG-1370_2.patch
>
>
> Done as a separate JIRA from PIG-1311 since this alone contains quite a lot of changes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message