hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Dai (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1363) Unnecessary loadFunc instantiations
Date Thu, 15 Apr 2010 20:48:49 GMT

    [ https://issues.apache.org/jira/browse/PIG-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857526#action_12857526
] 

Daniel Dai commented on PIG-1363:
---------------------------------

+1

> Unnecessary loadFunc instantiations
> -----------------------------------
>
>                 Key: PIG-1363
>                 URL: https://issues.apache.org/jira/browse/PIG-1363
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.8.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.0
>
>         Attachments: pig-1363.patch, pig-1363_1.patch
>
>
> In MRCompiler loadfuncs are instantiated at multiple locations in different visit methods.
This is inconsistent and confusing. LoadFunc should be instantiated at only one place, ideally
in LogToPhyTanslation#visit(LOLoad). A getter should be added to POLoad to retrieve this instantiated
loadFunc wherever it is needed in later stages of compilation. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message