hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Reed (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1307) when we spill the DefaultDataBag we are not setting the sized changed flag to be true.
Date Fri, 19 Mar 2010 22:50:27 GMT

    [ https://issues.apache.org/jira/browse/PIG-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847631#action_12847631
] 

Benjamin Reed commented on PIG-1307:
------------------------------------

i don't have test cases since the test cases would be orders of magnitude higher more difficult
to write than the patch and may not reproduce the problem across different machine configurations.

> when we spill the DefaultDataBag we are not setting the sized changed flag to be true.
> --------------------------------------------------------------------------------------
>
>                 Key: PIG-1307
>                 URL: https://issues.apache.org/jira/browse/PIG-1307
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Benjamin Reed
>            Assignee: Benjamin Reed
>             Fix For: 0.7.0
>
>         Attachments: PIG-1307.patch
>
>
> pig uses a size changed flag to indicate when we should recalculate the memory footprint
of the bag. the setting of this flag is sprinkled throughout the code. unfortunately, it is
missing in DefaultDataBag.spill(). there may be other cases as well. the problem with this
case is that when the low memory threshold kicks in, bags are spilled until the desired amount
of memory is "freed". since the flag is not being reset subsequent calls to the threshold
events will retrigger the spill() and think more memory was freed even though nothing was
actually spilled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message