hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1269) [Zebra] Restrict schema definition for collection
Date Thu, 11 Mar 2010 12:32:27 GMT

    [ https://issues.apache.org/jira/browse/PIG-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844048#action_12844048
] 

Hadoop QA commented on PIG-1269:
--------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12438479/zebra.0310
  against trunk revision 921585.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 66 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/242/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/242/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/242/console

This message is automatically generated.

> [Zebra] Restrict schema definition for collection
> -------------------------------------------------
>
>                 Key: PIG-1269
>                 URL: https://issues.apache.org/jira/browse/PIG-1269
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Xuefu Zhang
>            Assignee: Xuefu Zhang
>             Fix For: 0.7.0
>
>         Attachments: zebra.0310
>
>
> Currently Zebra grammar for schema definition for collection field allows many types
of definition. To reduce complexity and remove ambiguity, and more importantly, to make the
meta data more representative of the actual data instances, the grammar rules need to be changed.
Only a record type is allowed and required for collection definition. Thus,  fieldName:collection(record(c1:int,
c2:string)) is legal, while fieldName:collection(c1:int, c2:string), fieldName:collection(f:record(c1:int,
c2:string)), fieldName:collection(c1:int), or feildName:collection(int) is illegal.
> This will have some impact on existing Zebra M/R programs or Pig scripts that use Zebra.
Schema acceptable in previous release now may become illegal because of this change. This
should be clearly documented.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message