hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1190) Handling of quoted strings in pig-latin/grunt commands
Date Tue, 02 Feb 2010 04:32:20 GMT

    [ https://issues.apache.org/jira/browse/PIG-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828440#action_12828440
] 

Hadoop QA commented on PIG-1190:
--------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12434468/pig-1190.patch
  against trunk revision 905377.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/195/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/195/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/195/console

This message is automatically generated.

> Handling of quoted strings in pig-latin/grunt commands
> ------------------------------------------------------
>
>                 Key: PIG-1190
>                 URL: https://issues.apache.org/jira/browse/PIG-1190
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.7.0
>
>         Attachments: pig-1190.patch
>
>
> There is some inconsistency in the way quoted strings are used/handled in pig-latin .
> In load/store and define-ship commands, files are specified in quoted strings , and the
file name is the content within the quotes.  But in case of register, set, and file system
commands , if string is specified in quotes, the quotes are also included as part of the string.
This is not only inconsistent , it is also unintuitive. 
> This is also inconsistent with the way hdfs commandline (or bash shell) interpret file
names.
> For example, currently with the command - 
> set job.name 'job123'
> The job name set set to 'job123' (including the quotes) not job123 .
> This needs to be fixed, and above command should be considered equivalent to - set job.name
job123. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message