hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1046) join algorithm specification is within double quotes
Date Thu, 04 Feb 2010 14:16:28 GMT

    [ https://issues.apache.org/jira/browse/PIG-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829608#action_12829608

Hadoop QA commented on PIG-1046:

+1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 906326.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/199/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/199/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/199/console

This message is automatically generated.

> join algorithm specification is within double quotes
> ----------------------------------------------------
>                 Key: PIG-1046
>                 URL: https://issues.apache.org/jira/browse/PIG-1046
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.7.0
>         Attachments: pig-1046.patch, pig-1046_1.patch, pig-1046_2.patch, pig-1046_3.patch
> This fails -
> j = join l1 by $0, l2 by $0 using 'skewed';
> This works -
> j = join l1 by $0, l2 by $0 using "skewed";
> String constants are single-quoted in pig-latin. If the algorithm specification is supposed
to be a string, specifying it within single quotes should be supported.
> Alternatively, we should be using identifiers here, since these are pre-defined in pig
users will not be specifying arbitrary values that might not be valid identifier. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message