hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Olga Natkovich (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1190) Handling of quoted strings in pig-latin/grunt commands
Date Wed, 03 Feb 2010 23:47:28 GMT

    [ https://issues.apache.org/jira/browse/PIG-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829321#action_12829321
] 

Olga Natkovich commented on PIG-1190:
-------------------------------------

+1. The patch looks good.

One minor comment:

src/org/apache/pig/tools/grunt/GruntParser.java near line 422, we no longer need to compare
to quoted and unquoted versions of on/off. It would be nice to clean that up.

Once you update and re-attach the patch, you can go ahead and commit the changes (after running
ant test-commit). There is no need to re-reun test-patch since the change is mostly cosmetic.

> Handling of quoted strings in pig-latin/grunt commands
> ------------------------------------------------------
>
>                 Key: PIG-1190
>                 URL: https://issues.apache.org/jira/browse/PIG-1190
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.7.0
>
>         Attachments: pig-1190.patch
>
>
> There is some inconsistency in the way quoted strings are used/handled in pig-latin .
> In load/store and define-ship commands, files are specified in quoted strings , and the
file name is the content within the quotes.  But in case of register, set, and file system
commands , if string is specified in quotes, the quotes are also included as part of the string.
This is not only inconsistent , it is also unintuitive. 
> This is also inconsistent with the way hdfs commandline (or bash shell) interpret file
names.
> For example, currently with the command - 
> set job.name 'job123'
> The job name set set to 'job123' (including the quotes) not job123 .
> This needs to be fixed, and above command should be considered equivalent to - set job.name
job123. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message