hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pradeep Kamath (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1239) PigContext.connect() should not create a jobClient and jobClient should be created on demand when needed
Date Tue, 16 Feb 2010 20:33:27 GMT

    [ https://issues.apache.org/jira/browse/PIG-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834443#action_12834443
] 

Pradeep Kamath commented on PIG-1239:
-------------------------------------

* No unit tests are included in both patches since this is difficult to capture in a unit
test - manual tests were done to ensure that connections to JobTracker no longer happens from
a script using replicated join.
 * Release audit warning are due to diffs in html docs
 * The extra javac warnings are due to use of JobConf which is deprecated - I have added suppressWarning
tags which don't seem to help. We need to use JobConf here and there is no way around the
warning.

Results from running test-patch ant target for branch-0.6
   [exec] -1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified
tests.
     [exec]                         Please justify why no tests are needed for this patch.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     -1 release audit.  The applied patch generated 391 release audit warnings
(more than the trunk's current 389 warnings).
     [exec]
     [exec]
     [exec]
     [exec]
     [exec] ======================================================================
     [exec] ======================================================================
     [exec]     Finished build.
     [exec] ======================================================================
     [exec] ======================================================================

Results from running test-patch ant target for load-store-redesign branch:

     [exec] -1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified
tests.
     [exec]                         Please justify why no tests are needed for this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     -1 javac.  The applied patch generated 105 javac compiler warnings (more than
the trunk's current 103 warnings).
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
     [exec] 
     [exec] 



> PigContext.connect() should not create a jobClient and jobClient should be created on
demand when needed
> --------------------------------------------------------------------------------------------------------
>
>                 Key: PIG-1239
>                 URL: https://issues.apache.org/jira/browse/PIG-1239
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.6.0
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: 0.6.0, 0.7.0
>
>         Attachments: PIG-1239-branch-0.6.patch, PIG-1239-load-store-redesign-branch.patch
>
>
> PigContext.connect() currently connects to the jobtracker and creates a JobClient - this
causes issue in POMergeJoin/POFRJoin wherein these connections to the jobtracker are made
from each map task. The creation of the JobClient is not necessary in PigContext.connect()
and a JobClient should be created on demand where it is needed instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message