hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan (JIRA)" <j...@apache.org>
Subject [jira] Updated: (PIG-1251) Move SortInfo calculation earlier in compilation
Date Tue, 23 Feb 2010 02:09:27 GMT

     [ https://issues.apache.org/jira/browse/PIG-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ashutosh Chauhan updated PIG-1251:
----------------------------------

    Attachment: pig-1251.patch

Patch which moves SortInfo calculation from LogToPhyTranslation to SortInfoSetter. This facilitate
calling checkSchema() before checkOutputSpecs() during store location validation. 
Result of test-patch
{noformat}
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec] 
     [exec]     -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
     [exec] 
     [exec] 
{noformat}

Javadoc warning is unrelated to the patch.

> Move SortInfo calculation earlier in compilation 
> -------------------------------------------------
>
>                 Key: PIG-1251
>                 URL: https://issues.apache.org/jira/browse/PIG-1251
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: pig-1251.patch
>
>
> In LSR Pig does Input Output Validation by calling hadoop's checkSpecs() A storefunc
might need schema to do such a validation. So, we should call checkSchema() before doing the
validation. checkSchema() in turn requires SortInfo which is calculated later in compilation
phase. We need to move it earlier in compilation phase. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message