hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Olga Natkovich (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1046) join algorithm specification is within double quotes
Date Thu, 04 Feb 2010 19:43:29 GMT

    [ https://issues.apache.org/jira/browse/PIG-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829731#action_12829731
] 

Olga Natkovich commented on PIG-1046:
-------------------------------------

(1) I think the error message should be made a little more clear on invalid cogroup modifier.
Something like:

Only COLLECTED or REGULAR are valid GROUP modifiers.

(2) There seems to be some code duplication to support doubequotes. It would be better if
you just had warning for deprication but then had the rest of the code in one place.

(3) Similar comments for the join part.

> join algorithm specification is within double quotes
> ----------------------------------------------------
>
>                 Key: PIG-1046
>                 URL: https://issues.apache.org/jira/browse/PIG-1046
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.7.0
>
>         Attachments: pig-1046.patch, pig-1046_1.patch, pig-1046_2.patch, pig-1046_3.patch
>
>
> This fails -
> j = join l1 by $0, l2 by $0 using 'skewed';
> This works -
> j = join l1 by $0, l2 by $0 using "skewed";
> String constants are single-quoted in pig-latin. If the algorithm specification is supposed
to be a string, specifying it within single quotes should be supported.
> Alternatively, we should be using identifiers here, since these are pre-defined in pig
users will not be specifying arbitrary values that might not be valid identifier. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message