hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1106) FR join should not spill
Date Sat, 12 Dec 2009 00:38:18 GMT

    [ https://issues.apache.org/jira/browse/PIG-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789623#action_12789623
] 

Hadoop QA commented on PIG-1106:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12427716/frjoin-nonspill.patch
  against trunk revision 889346.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/118/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/118/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/118/console

This message is automatically generated.

> FR join should not spill
> ------------------------
>
>                 Key: PIG-1106
>                 URL: https://issues.apache.org/jira/browse/PIG-1106
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>            Assignee: Ankit Modi
>             Fix For: 0.7.0
>
>         Attachments: frjoin-nonspill.patch
>
>
> Currently, the values for the replicated side of the data are placed in a spillable bag
(POFRJoin near line 275). This does not make sense because the whole point of the optimization
is that the data on one side fits into memory. We already have a non-spillable bag implemented
(NonSpillableDataBag.java) and we need to change FRJoin code to use it. And of course need
to do lots of testing to make sure that we don't spill but die instead when we run out of
memory

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message