hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas M Nair (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1149) Allow instantiation of SampleLoaders with parametrized LoadFuncs
Date Mon, 21 Dec 2009 17:22:18 GMT

    [ https://issues.apache.org/jira/browse/PIG-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793269#action_12793269
] 

Thejas M Nair commented on PIG-1149:
------------------------------------

+1 to the lsr branch version.
But the FIXME comment in the test case is not correct. There does not have to be > 1 samples
sampled for every map, if the number of rows are very small. Though this behavior is different
from earlier version of the trunk version of poisson sampler, it satisfies the requirements
as per http://wiki.apache.org/pig/PigSampler and PIG-1062.
I can remove the FIXME comment as part of the patch I am going to submit to fix the other
test case.


> Allow instantiation of SampleLoaders with parametrized LoadFuncs
> ----------------------------------------------------------------
>
>                 Key: PIG-1149
>                 URL: https://issues.apache.org/jira/browse/PIG-1149
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>            Priority: Minor
>             Fix For: 0.7.0
>
>         Attachments: pig_1149.patch, pig_1149_lsr-branch.patch
>
>
> Currently, it is not possible to instantiate a SampleLoader with something like PigStorage(':').
 We should allow passing parameters to the loaders being sampled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message