hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas M Nair (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1149) Allow instantiation of SampleLoaders with parametrized LoadFuncs
Date Fri, 18 Dec 2009 20:27:18 GMT

    [ https://issues.apache.org/jira/browse/PIG-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792627#action_12792627
] 

Thejas M Nair commented on PIG-1149:
------------------------------------

I notice that this patch is using org.mortbay.log instead of org.apache.commons.logging. That
is not used anywhere else in pig code. Should we replace that with org.apache.commons.logging
?

A small change is required to get the patch working with load-store branch. It no longer requires
the load func to implement SampleLoader interface, and that interface has been removed. I
can submit the modified patch. 
{code}
+        loader = (SamplableLoader)PigContext.instantiateFuncFromSpec(funcSpec);
{code}
changes to 
+        loader = (LoadFunc)PigContext.instantiateFuncFromSpec(funcSpec);
{code}


> Allow instantiation of SampleLoaders with parametrized LoadFuncs
> ----------------------------------------------------------------
>
>                 Key: PIG-1149
>                 URL: https://issues.apache.org/jira/browse/PIG-1149
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>            Priority: Minor
>             Fix For: 0.7.0
>
>         Attachments: pig_1149.patch
>
>
> Currently, it is not possible to instantiate a SampleLoader with something like PigStorage(':').
 We should allow passing parameters to the loaders being sampled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message