hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-598) Parameter substitution ($PARAMETER) should not be performed in comments
Date Mon, 23 Nov 2009 20:27:40 GMT

    [ https://issues.apache.org/jira/browse/PIG-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781602#action_12781602
] 

Ashutosh Chauhan commented on PIG-598:
--------------------------------------


bq. compared to the cost of time spending debugging a weird error or unexpected output results,
the cost of a for the user is trivial.

I agree. Catching errors early and providing clear explanation for it is more important then
the convenience of not requiring escaping. Thus a) is better.

bq. we should support an option where user can change from default behavior (a) to (b) using
a commandline switch or a statement in the script.

Adding yet another hook may not be worth the complexity/time. Lets keep this on hold unless
someone specifically asks for this.

> Parameter substitution ($PARAMETER) should not be performed in comments
> -----------------------------------------------------------------------
>
>                 Key: PIG-598
>                 URL: https://issues.apache.org/jira/browse/PIG-598
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.2.0
>            Reporter: David Ciemiewicz
>            Assignee: Thejas M Nair
>         Attachments: PIG-598.1.patch, PIG-598.patch
>
>
> Compiling the following code example will generate an error that $NOT_A_PARAMETER is
an Undefined Parameter.
> This is problematic as sometimes you want to comment out parts of your code, including
parameters so that you don't have to define them.
> This I think it would be really good if parameter substitution was not performed in comments.
> {code}
> -- $NOT_A_PARAMETER
> {code}
> {code}
> -bash-3.00$ pig -exectype local -latest comment.pig
> USING: /grid/0/gs/pig/current
> java.lang.RuntimeException: Undefined parameter : NOT_A_PARAMETER
>         at org.apache.pig.tools.parameters.PreprocessorContext.substitute(PreprocessorContext.java:221)
>         at org.apache.pig.tools.parameters.ParameterSubstitutionPreprocessor.parsePigFile(ParameterSubstitutionPreprocessor.java:106)
>         at org.apache.pig.tools.parameters.ParameterSubstitutionPreprocessor.genSubstitutedFile(ParameterSubstitutionPreprocessor.java:86)
>         at org.apache.pig.Main.runParamPreprocessor(Main.java:394)
>         at org.apache.pig.Main.main(Main.java:296)
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message