hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Dai (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1043) FINDBUGS: SIC_INNER_SHOULD_BE_STATIC: Should be a static inner class
Date Sat, 24 Oct 2009 00:43:59 GMT

    [ https://issues.apache.org/jira/browse/PIG-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769555#action_12769555
] 

Daniel Dai commented on PIG-1043:
---------------------------------

Some conflicts with the current trunk. +1 once conflict solves.

> FINDBUGS: SIC_INNER_SHOULD_BE_STATIC: Should be a static inner class
> --------------------------------------------------------------------
>
>                 Key: PIG-1043
>                 URL: https://issues.apache.org/jira/browse/PIG-1043
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Olga Natkovich
>            Assignee: Olga Natkovich
>         Attachments: PIG-1043.patch
>
>
> SIC 	Should org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.CombinerOptimizer$AlgebraicPlanChecker
be a _static_ inner class?
> SIC 	Should org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.CombinerOptimizer$DistinctPatcher
be a _static_ inner class?
> SIC 	Should org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.CombinerOptimizer$fixMapProjects
be a _static_ inner class?
> SIC 	Should org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.KeyTypeDiscoveryVisitor$PhyPlanKeyTypeVisitor
be a _static_ inner class?
> SIC 	Should org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MapReducePOStoreImpl$StoreFuncAdaptor
be a _static_ inner class?
> SIC 	Should org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MRCompiler$FindKeyTypeVisitor
be a _static_ inner class?
> SIC 	Should org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.NoopStoreRemover$RemovableStore
be a _static_ inner class?
> SIC 	Should org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.plans.DotMRPrinter$InnerOperator
be a _static_ inner class?
> SIC 	Should org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.plans.POPackageAnnotator$LoRearrangeDiscoverer
be a _static_ inner class?
> SIC 	Should org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.plans.POPackageAnnotator$PackageDiscoverer
be a _static_ inner class?
> SIC 	Should org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POCogroup$groupComparator
be a _static_ inner class?
> SIC 	Should org.apache.pig.data.DistinctDataBag$DistinctDataBagIterator$TContainer be
a _static_ inner class?
> SIC 	Should org.apache.pig.data.SortedDataBag$DefaultComparator be a _static_ inner class?
> SIC 	Should org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor$ScoreFuncSpecListComparator
be a _static_ inner class?
> SIC 	Should org.apache.pig.shock.SSHSocketImplFactory$SSHProcess be a _static_ inner
class?
> SIC 	Should org.apache.pig.tools.grunt.GruntParser$ExplainState be a _static_ inner class?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message