hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitriy V. Ryaboy (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-790) Error message should indicate in which line number in the Pig script the error occured (debugging BinCond)
Date Tue, 20 Oct 2009 23:55:59 GMT

    [ https://issues.apache.org/jira/browse/PIG-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768018#action_12768018
] 

Dmitriy V. Ryaboy commented on PIG-790:
---------------------------------------

This bit of code is repeated almost a dozen times:

<code>
            String alias = currentAlias;
            if (binOp.getAlias()!=null)
                alias = binOp.getAlias();
            String msg = "In alias " + alias + ", ";
</code>

This class is already clocking in at over 2500 lines..

Make it a helper function, shrink the class a bit?

> Error message should indicate in which line number in the Pig script the error occured
(debugging BinCond)
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: PIG-790
>                 URL: https://issues.apache.org/jira/browse/PIG-790
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.4.0
>            Reporter: Viraj Bhat
>            Assignee: Daniel Dai
>            Priority: Minor
>             Fix For: 0.6.0
>
>         Attachments: error_rerport.pig, myerrordata.txt, PIG-790-1.patch, pig_1240972895275.log
>
>
> I have a simple Pig script which loads integer data and does a Bincond, where it compares,
(col1 eq ''). There is an error message that is generated in this case, but it does not specify
the line number in the script. 
> {code}
> MYDATA = load '/user/viraj/myerrordata.txt' using PigStorage() as (col1:int, col2:int);
> MYDATA_PROJECT = FOREACH MYDATA GENERATE ((col1 eq '') ? 1 : 0) as newcol1,
>                                          ((col1 neq '') ? col1 - col2 : 160000)
>                                                         as time_diff;
> dump MYDATA_PROJECT;
> {code}
> ======================================
> 2009-04-29 02:33:07,182 [main] INFO  org.apache.pig.backend.hadoop.executionengine.HExecutionEngine
- Connecting to hadoop file system at: hdfs://localhost:9000
> 2009-04-29 02:33:08,584 [main] INFO  org.apache.pig.backend.hadoop.executionengine.HExecutionEngine
- Connecting to map-reduce job tracker at: localhost:9001
> 2009-04-29 02:33:08,836 [main] INFO  org.apache.pig.PigServer - Create a new graph.
> 2009-04-29 02:33:10,040 [main] ERROR org.apache.pig.tools.grunt.Grunt - ERROR 1039: Incompatible
types in EqualTo Operator left hand side:int right hand side:chararray
> Details at logfile: /home/viraj/pig-svn/trunk/pig_1240972386081.log
> ==========================
> It would be good if the error message has a line number and a copy of the line in the
script which is causing the problem.
> Attaching data, script and log file. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message