hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1052) FINDBUGS: remaining performance warnings
Date Wed, 28 Oct 2009 18:31:59 GMT

    [ https://issues.apache.org/jira/browse/PIG-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771040#action_12771040
] 

Hadoop QA commented on PIG-1052:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12423381/PIG-1052.patch
  against trunk revision 830335.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/122/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/122/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/122/console

This message is automatically generated.

> FINDBUGS: remaining performance warnings
> ----------------------------------------
>
>                 Key: PIG-1052
>                 URL: https://issues.apache.org/jira/browse/PIG-1052
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Olga Natkovich
>         Attachments: PIG-1052.patch
>
>
> SBSC 	Method org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.Launcher.getStackTraceElement(String)
concatenates strings using + in a loop
> SBSC 	Method org.apache.pig.impl.logicalLayer.LOCross.getSchema() concatenates strings
using + in a loop
> SBSC 	Method org.apache.pig.impl.logicalLayer.LOForEach.getSchema() concatenates strings
using + in a loop
> SBSC 	Method org.apache.pig.PigServer.locateJarFromResources(String) concatenates strings
using + in a loop
> SBSC 	Method org.apache.pig.tools.parameters.ParseException.initialise(Token, int[][],
String[]) concatenates strings using + in a loop
> SBSC 	Method org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String)
concatenates strings using + in a loop
> SS 	Unread field: org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.Launcher.OOM_ERR;
should this field be static?
> SS 	Unread field: org.apache.pig.impl.io.BufferedPositionedInputStream.bufSize; should
this field be static?
> UPM 	Private method org.apache.pig.impl.plan.optimizer.RulePlanPrinter.planString(List)
is never called
> UPM 	Private method org.apache.pig.impl.plan.PlanPrinter.planString(List) is never called
> WMI 	Method org.apache.pig.builtin.PigStorage.putField(Object) makes inefficient use
of keySet iterator instead of entrySet iterator
> WMI 	Method org.apache.pig.data.DataType.mapToString(Map) makes inefficient use of keySet
iterator instead of entrySet iterator
> WMI 	Method org.apache.pig.impl.logicalLayer.LOCross.getSchema() makes inefficient use
of keySet iterator instead of entrySet iterator
> WMI 	Method org.apache.pig.impl.logicalLayer.LOForEach.getSchema() makes inefficient
use of keySet iterator instead of entrySet iterator
> WMI 	Method org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.getLoadFuncSpec(Schema$FieldSchema,
String) makes inefficient use of keySet iterator instead of entrySet iterator
> WMI 	Method org.apache.pig.impl.plan.CompilationMessageCollector.logAggregate(Map, CompilationMessageCollector$MessageType,
Log) makes inefficient use of keySet iterator instead of entrySet iterator
> WMI 	Method org.apache.pig.StandAloneParser.tryParse(String) makes inefficient use of
keySet iterator instead of entrySet iterator

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message